New issue
Advanced search Search tips

Issue 895940 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

Experiment with trimming everything but the Origin for Steady State Elisions

Project Member Reported by tommycli@chromium.org, Oct 16

Issue description

Experiment with trimming everything but the Origin for Steady State Elisions

This is consistent with what iOS already does.
 
Platforms = desktop only ?
Labels: -Type-Bug OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows Type-Feature
Hey Mark, on all platforms, thanks.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601

commit bef94ee00fcb2b8a94fbd9b0323094fbc37e9601
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Oct 17 19:56:36 2018

Omnibox: Steady State Elisions - Add a trim everything but origin flag

Trims the userinfo (username and password), path, query and ref.

iOS already does this. This just reuses the same URL formatting logic
on other platforms.

We should rename the URLFormatter flag in a followup CL for consistency.

This does not get all the text interactions perfect. For example,
pressing the right arrow key on the elided URL will place the cursor
at the end of the host, not the end of the full URL.

It's not 100% clear what the right text interactions are yet, but this
is a first step towards experimenting with these issues.

Bug: 895940
Change-Id: I959c4e33cc28022110db247eeb6e8c38b9fcb672
Reviewed-on: https://chromium-review.googlesource.com/c/1284053
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600526}
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/chrome/browser/about_flags.cc
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/components/toolbar/toolbar_field_trial.cc
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/components/toolbar/toolbar_field_trial.h
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/bef94ee00fcb2b8a94fbd9b0323094fbc37e9601/tools/metrics/histograms/enums.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57e6895a1473287fc615d14591b99154f6e219f0

commit 57e6895a1473287fc615d14591b99154f6e219f0
Author: Tommy C. Li <tommycli@chromium.org>
Date: Fri Jan 18 01:22:19 2019

Omnibox: Steady State Elisions - Fade out the path over time

This is experimental and only applies if a special feature flag is on.

For Views only, this will fade out the path over time instead of the
path just being hidden.

This allows users to see the path on page load, mouseover, and for
inspecting error pages.

Bug: 895940
Change-Id: I74d155180e500fbba2529f89200e10375a3874cf
Reviewed-on: https://chromium-review.googlesource.com/c/1409963
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623938}
[modify] https://crrev.com/57e6895a1473287fc615d14591b99154f6e219f0/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/57e6895a1473287fc615d14591b99154f6e219f0/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/57e6895a1473287fc615d14591b99154f6e219f0/components/omnibox/browser/location_bar_model_impl.cc
[modify] https://crrev.com/57e6895a1473287fc615d14591b99154f6e219f0/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/57e6895a1473287fc615d14591b99154f6e219f0/components/omnibox/browser/omnibox_view.h

Sign in to add a comment