New issue
Advanced search Search tips

Issue 895928 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Query in Omnibox makes search-based tab switch suggestions not match

Project Member Reported by k...@chromium.org, Oct 16

Issue description

Chrome Version: 71.0.3577.0
OS: Linux

What steps will reproduce the problem?
(1) Enable Query in Omnibox
(2) Enter "harry potter" in one tab,
(3) Type but don't enter "harry potter" in another tab.

What is the expected result?
That a suggestion, perhaps the first, would refer to the first tab.

What happens instead?
There is no indication of a matching tab.

If you disable Query in Omnibox, a suggestion will indicate that it matches.

 
Labels: Needs-Feedback
Owner: k...@chromium.org
krb@ might this have been fixed super-recently?
Can't repro on 72.0.3582.0, Windows Canary

i.e. I get 1-2 matching tab suggestions even if Query in Omnibox is on.
(2 can happen if the entity matches)
internal: https://screenshot.googleplex.com/b9cEyPyK6Jq
or it could be OS-specific. If that's the case please assign to me and I'll try to repro on linux (unable to at the moment unfortunately)
As I try it more, I'm seeing a more inconsistent behavior. If I enable Query, and repeatedly shut-down and restart the browser, I'm seeing about a 50% success rate . But when I disable Query, I get a 100% success rate. I would avoid testing after the restart after changing a flag, but instead do a full restart.

So I don't specifically know if this is Query's fault, but I can definitely reproduce and there's a correlation with Query. And since it's inconsistent, yes, it may be OS-specific.
Labels: -Needs-Feedback
Status: Assigned (was: Untriaged)
Cc: mpear...@chromium.org
I just retried this, on the assumption that I imagined it, or that it was caused by not refreshing the first window after a settings-change restart. It reproduces without Query but the symptom is more weird. When I type the last 'r', the first suggestion flashes an AiS suggestion, and also matches the other tab, but then goes to a plain search, that doesn't match.

Pressing enter and looking at the URL reveals that the aqs parameter keeps changing. Perhaps we should ignore it.

Unfortunately, actually visiting the page appears to have changed my history results or something, because now it's gone. I'll try to grab about:omnibox if I see it again.

Mark, do we still have an outstanding async issue? I thought we had gotten them all.

Here's the current about:omnibox in case it's helpful.

cursor position = -1

inferred input type = query

elapsed time = 103ms

all providers done = true

host = harry potter has isTypedHost = false

Combined results.
Provider	Type	Relevance	Contents	Can Be Default	Starred	Has tab match	Description	URL	Fill Into Edit	Inline Autocompletion	Del	Prev	Tran	Done	Associated Keyword	Keyword	Duplicates	Additional Info
Search	search-what-you-typed	1300	harry potter	true	false	false	Google Search	https://www.google.com/search?q=harry+potter&oq=harry+potter&aqs=chrome..69i57j69i60l2j0l3&sourceid=chrome&ie=UTF-8	harry potter		false	false	5	true		google.com	11	
relevance_from_server:	true
should_prefetch:	false
HistoryQuick	history-url	820	en.wikipedia.org/wiki/Harry_Potter	false	false	false	Harry Potter - Wikipedia	https://en.wikipedia.org/wiki/Harry_Potter	https://en.wikipedia.org/wiki/Harry_Potter		true	false	1	true			0	
last visit:	171 hours ago
typed count:	0
visit count:	1
HistoryQuick	history-url	781	en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter	false	false	false	Harry Potter - Wikipedia	https://en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter	https://en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter		true	false	1	true			0	
last visit:	171 hours ago
typed count:	0
visit count:	1
Search	search-suggest	601	harry potter movies	false	false	false	Google Search	https://www.google.com/search?q=harry+potter+movies&oq=harry+potter&aqs=chrome.3.69i57j69i60l2j0l3&sourceid=chrome&ie=UTF-8	harry potter movies		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	600	harry potter cast	false	false	false		https://www.google.com/search?q=harry+potter+cast&oq=harry+potter&aqs=chrome.4.69i57j69i60l2j0l3&sourceid=chrome&ie=UTF-8	harry potter cast		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	566	harry potter costume	false	false	false		https://www.google.com/search?q=harry+potter+costume&oq=harry+potter&aqs=chrome.5.69i57j69i60l2j0l3&sourceid=chrome&ie=UTF-8	harry potter costume		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false

Results for individual providers.
Provider	Type	Relevance	Contents	Can Be Default	Starred	Has tab match	Description	URL	Fill Into Edit	Inline Autocompletion	Del	Prev	Tran	Done	Associated Keyword	Keyword	Duplicates	Additional Info
HistoryQuick	history-url	820	en.wikipedia.org/wiki/Harry_Potter	false	false	false	Harry Potter - Wikipedia	https://en.wikipedia.org/wiki/Harry_Potter	https://en.wikipedia.org/wiki/Harry_Potter		true	false	1	true			0	
last visit:	171 hours ago
typed count:	0
visit count:	1
HistoryQuick	history-url	781	en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter	false	false	false	Harry Potter - Wikipedia	https://en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter	https://en.wikipedia.org/w/index.php?title=Special:Search&search=Harry+Potter		true	false	1	true			0	
last visit:	171 hours ago
typed count:	0
visit count:	1

Provider	Type	Relevance	Contents	Can Be Default	Starred	Has tab match	Description	URL	Fill Into Edit	Inline Autocompletion	Del	Prev	Tran	Done	Associated Keyword	Keyword	Duplicates	Additional Info
Search	search-what-you-typed	1300	harry potter	true	false	false		https://www.google.com/search?q=harry+potter&sourceid=chrome&ie=UTF-8	harry potter		false	false	5	true		google.com	10	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	601	harry potter movies	false	false	false		https://www.google.com/search?q=harry+potter+movies&oq=harry+potter&sourceid=chrome&ie=UTF-8	harry potter movies		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	600	harry potter cast	false	false	false		https://www.google.com/search?q=harry+potter+cast&oq=harry+potter&sourceid=chrome&ie=UTF-8	harry potter cast		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	566	harry potter costume	false	false	false		https://www.google.com/search?q=harry+potter+costume&oq=harry+potter&sourceid=chrome&ie=UTF-8	harry potter costume		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	565	harry potter characters	false	false	false		https://www.google.com/search?q=harry+potter+characters&oq=harry+potter&sourceid=chrome&ie=UTF-8	harry potter characters		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false
Search	search-suggest	564	harry potter house quiz	false	false	false		https://www.google.com/search?q=harry+potter+house+quiz&oq=harry+potter&sourceid=chrome&ie=UTF-8	harry potter house quiz		false	false	5	true		google.com	0	
relevance_from_server:	true
should_prefetch:	false

Provider	Type	Relevance	Contents	Can Be Default	Starred	Has tab match	Description	URL	Fill Into Edit	Inline Autocompletion	Del	Prev	Tran	Done	Associated Keyword	Keyword	Duplicates	Additional Info
Shortcuts	search-history	1199	harry potter	true	false	false	Google Search	https://www.google.com/search?q=harry+potter&oq=harry+potter&aqs=chrome..69i57j69i60l2j0l3.29717j1j7&sourceid=chrome&ie=UTF-8	harry potter		true	false	5	true		google.com	0	
last access time:	0 hours ago
number of hits:	1
original input text:	harry potter

Status: Closed (was: Assigned)
I haven't been able to duplicate this in a couple weeks. Closing.

Sign in to add a comment