getContextAttributes should specify lowLatency value |
|||||||||
Issue description
Chrome Version: 70.0.3538.54, 72.0.3582.0
OS: Win10
What steps will reproduce the problem?
(1) Enable chrome://flags/#enable-experimental-web-platform-features
(2) Request a WebGL context with {lowLatency: true}.
(3) Call getContextAttributes() on the context.
(4) Note that the lowLatency value is not in the returned attributes.
What is the expected result?
The returned attributes have lowLatency: true or false based on the actual context attributes.
What happens instead?
No lowLatency value is returned.
Please use labels and text to provide additional information.
If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
,
Oct 22
Issue 897787 has been merged into this issue.
,
Oct 22
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e9987d9eb2925d5454685a7374455d5aebae9a7 commit 9e9987d9eb2925d5454685a7374455d5aebae9a7 Author: Miguel Casas <mcasas@chromium.org> Date: Tue Oct 23 14:21:29 2018 Canvas LowLatency: wire lowLatency in getContextAttributes() This CL wires |lowLatency| in WebGL's getContextAttributes(), and adds LayoutTests entries wherever appropriate. Also cleans up the {} in canvas_rendering_context.cc (adds or removes them where appropriate). Bug: 895918 Change-Id: I08872f45cbadbf0772c92a761dee15243bd4f17a Reviewed-on: https://chromium-review.googlesource.com/c/1294301 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#601943} [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/WebKit/LayoutTests/fast/canvas-api/canvas-lowlatency-getContext.html [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/WebKit/LayoutTests/fast/webgl/webgl-context-attributes-default-value-expected.txt [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/WebKit/LayoutTests/fast/webgl/webgl-context-attributes-default-value.html [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/blink/renderer/modules/webgl/webgl_context_attribute_helpers.cc [modify] https://crrev.com/9e9987d9eb2925d5454685a7374455d5aebae9a7/third_party/blink/renderer/modules/webgl/webgl_context_attributes.idl
,
Oct 23
https://storage.googleapis.com/chromium-find-releases-static/9e9.html#9e9987d9eb2925d5454685a7374455d5aebae9a7 will tell the exact version where this was fixed.
,
Oct 24
Landed in 72.0.3590.0 Requesting merge-to-71, it's a low-risk change that only affects the lowLatency code path (on an Origin Trial 71-72-73)
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25
How is the change looking in canary? Is it safe to merge now?
,
Oct 25
The change only affects the lowLatency code path, which is controlled by an OriginTrial, so it should be safe. The fix has been confirmed by wfurr@ in cc.
,
Oct 25
Approving merge to M71 branch 3578 based on comments #6 and #9. Please merge ASAP.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5675143d40fd6524180e6fdd0add02de844f19c0 commit 5675143d40fd6524180e6fdd0add02de844f19c0 Author: Miguel Casas <mcasas@chromium.org> Date: Thu Oct 25 16:39:51 2018 Canvas LowLatency: wire lowLatency in getContextAttributes() This CL wires |lowLatency| in WebGL's getContextAttributes(), and adds LayoutTests entries wherever appropriate. Also cleans up the {} in canvas_rendering_context.cc (adds or removes them where appropriate). Bug: 895918 Change-Id: I08872f45cbadbf0772c92a761dee15243bd4f17a Reviewed-on: https://chromium-review.googlesource.com/c/1294301 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601943}(cherry picked from commit 9e9987d9eb2925d5454685a7374455d5aebae9a7) Reviewed-on: https://chromium-review.googlesource.com/c/1299438 Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#323} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/WebKit/LayoutTests/fast/canvas-api/canvas-lowlatency-getContext.html [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/WebKit/LayoutTests/fast/webgl/webgl-context-attributes-default-value-expected.txt [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/WebKit/LayoutTests/fast/webgl/webgl-context-attributes-default-value.html [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/blink/renderer/modules/webgl/webgl_context_attribute_helpers.cc [modify] https://crrev.com/5675143d40fd6524180e6fdd0add02de844f19c0/third_party/blink/renderer/modules/webgl/webgl_context_attributes.idl
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5675143d40fd6524180e6fdd0add02de844f19c0 Commit: 5675143d40fd6524180e6fdd0add02de844f19c0 Author: mcasas@chromium.org Commiter: mcasas@chromium.org Date: 2018-10-25 16:39:51 +0000 UTC Canvas LowLatency: wire lowLatency in getContextAttributes() This CL wires |lowLatency| in WebGL's getContextAttributes(), and adds LayoutTests entries wherever appropriate. Also cleans up the {} in canvas_rendering_context.cc (adds or removes them where appropriate). Bug: 895918 Change-Id: I08872f45cbadbf0772c92a761dee15243bd4f17a Reviewed-on: https://chromium-review.googlesource.com/c/1294301 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601943}(cherry picked from commit 9e9987d9eb2925d5454685a7374455d5aebae9a7) Reviewed-on: https://chromium-review.googlesource.com/c/1299438 Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#323} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vmiura@google.com
, Oct 19Owner: ----
Status: Available (was: Untriaged)