New issue
Advanced search Search tips

Issue 895907 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 788439



Sign in to add a comment

Add a UseCounter for lowLatency canvas contexts

Project Member Reported by mcasas@chromium.org, Oct 16

Issue description

For the Origin Trial we'd like to get some numbers re. lowLatency, so
let's add a UseCounter, probably in the vicinity of 
HTMLCanvasElementModule::getContext()
 
Blocking: 788439
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b045388d3008951278d3a277bd3cfee16063c94d

commit b045388d3008951278d3a277bd3cfee16063c94d
Author: Miguel Casas <mcasas@chromium.org>
Date: Mon Oct 22 16:17:26 2018

Canvas lowLatency: add UseCounter

This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to
complement said experiment, see the feature entry in
https://www.chromestatus.com/feature/6360971442388992

Bug:  895907 
Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36
Reviewed-on: https://chromium-review.googlesource.com/c/1293557
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601605}
[modify] https://crrev.com/b045388d3008951278d3a277bd3cfee16063c94d/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/b045388d3008951278d3a277bd3cfee16063c94d/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/b045388d3008951278d3a277bd3cfee16063c94d/tools/metrics/histograms/enums.xml

Labels: Merge-Request-71
Status: Fixed (was: Assigned)
Requesting merge to M71 since the intent to experiment associated
with the UseCounter landed in #2 was started in that branch. 

The CL is trivial and low risk to merge.
Pls apply appropriate OSs label.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
The merge-request applies to all platforms.
Status: Started (was: Fixed)
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 23

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 23

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8

commit 7575e6b6d98b3733d59081e615a3c8d39ce8bfd8
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Oct 23 18:10:34 2018

Canvas lowLatency: add UseCounter

This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to
complement said experiment, see the feature entry in
https://www.chromestatus.com/feature/6360971442388992

TBR=mcasas@chromium.org

(cherry picked from commit b045388d3008951278d3a277bd3cfee16063c94d)

Bug:  895907 
Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36
Reviewed-on: https://chromium-review.googlesource.com/c/1293557
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601605}
Reviewed-on: https://chromium-review.googlesource.com/c/1296676
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#269}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/tools/metrics/histograms/enums.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8

commit 7575e6b6d98b3733d59081e615a3c8d39ce8bfd8
Author: Miguel Casas <mcasas@chromium.org>
Date: Tue Oct 23 18:10:34 2018

Canvas lowLatency: add UseCounter

This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to
complement said experiment, see the feature entry in
https://www.chromestatus.com/feature/6360971442388992

TBR=mcasas@chromium.org

(cherry picked from commit b045388d3008951278d3a277bd3cfee16063c94d)

Bug:  895907 
Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36
Reviewed-on: https://chromium-review.googlesource.com/c/1293557
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601605}
Reviewed-on: https://chromium-review.googlesource.com/c/1296676
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#269}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8/tools/metrics/histograms/enums.xml

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7575e6b6d98b3733d59081e615a3c8d39ce8bfd8

Commit: 7575e6b6d98b3733d59081e615a3c8d39ce8bfd8
Author: mcasas@chromium.org
Commiter: mcasas@chromium.org
Date: 2018-10-23 18:10:34 +0000 UTC

Canvas lowLatency: add UseCounter

This CL adds a UseCounter for HTMLCanvas lowLatency use cases, to
complement said experiment, see the feature entry in
https://www.chromestatus.com/feature/6360971442388992

TBR=mcasas@chromium.org

(cherry picked from commit b045388d3008951278d3a277bd3cfee16063c94d)

Bug:  895907 
Change-Id: I7e81c4f317816b301d0845fc4561c8966000db36
Reviewed-on: https://chromium-review.googlesource.com/c/1293557
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601605}
Reviewed-on: https://chromium-review.googlesource.com/c/1296676
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#269}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)

Sign in to add a comment