Issue 895898 link

Starred by 4 users

Issue metadata

Status:	Assigned
Owner:	dvadym@chromium.org
Cc:	dvadym@chromium.org mahmadi@chromium.org nzolghadr@chromium.org ajuma@chromium.org █ noyau@chromium.org olivierrobin@chromium.org ios-bugs@chromium.org
Components:	UI>Browser>Passwords
EstimatedDays:	----
NextAction:	----
OS:	iOS
Pri:	2
Type:	Bug
Hotlist-Interop

Autofill on iOS: React doesn't notice changed values

Project Member Reported by ajuma@chromium.org, Oct 16

Issue description

This comes from https://github.com/facebook/react/issues/1159#issuecomment-424106865

Test case: https://jquense.github.io/browser-test-pages/autofill/login/

Steps to repro:
1) Visit the test page. Make up some user name and password, and submit. When the autofill UI appears, choose to save the password.
2) Visit the page again. Observe that the user name and password are filled in, but no onChange or onInput events are received for either field (the events are logged in the area beneath the Submit button).

Compare this to Safari, where onInput and onChange events are fired for both fields.

Tested on iOS 12, using Chrome 69.

Reading through the discussion at https://github.com/facebook/react/issues/1159, it sounds like the fix added by https://chromium-review.googlesource.com/c/chromium/src/+/844324 no longer works because React wasn't aware that Chrome depended on setting the |simulated| flag, so removed that behavior. See https://github.com/facebook/react/issues/1159#issuecomment-416996402.

This bug was pointed out to the web platform team by Facebook as an example of interop issues they are running into.

mahmadi@, can you please help triage this? Thanks!

Comment 1 by mahmadi@chromium.org, Oct 16

Cc: -olivierrobin@chromium.org mahmadi@chromium.org
Owner: olivierrobin@chromium.org
Status: Assigned (was: Untriaged)

Hi Olivier, could you please take a look?

Comment 2 by olivierrobin@chromium.org, Oct 16

We knew this could happen.
I will take a look tomorrow.

Comment 3 by olivierrobin@chromium.org, Oct 17

The test page does not seem to work on iOS 12, on safari, on Chrome or on Desktop.
It seems that the submit button is not submitting anything.

Comment 4 by ajuma@chromium.org, Oct 17

I hadn't noticed earlier, but it turns out that for the Submit button to work, the user name has to literally be "someUser" and the password has to literally be "somePass". Other username and password combos do nothing.

Comment 5 by olivierrobin@chromium.org, Oct 17

I made a lot of tests. My understanding is that this is a password bug.
If I understand correctly, the same test with an address would work (asking the react people to build a test page would be great).

The thing is that password does not use __gCrWeb.fill.setInputValue which handle the fields having property setter (which is the case of React).

So the best fix would be to fix password and use __gCrWeb.fill.setInputValue in password_controller.js

Adding dvadym@ from password to see if this can be prioritized.