Flaky test: WidgetTest.DestroyedWithCaptureViaEventMonitor Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=40963527dfeac410 Test output log: https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29/45187 Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I1dcb9f7786885210ea56b0c3c3f7134e21228de1 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ8Y2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS80NTE4Ny92aWV3c191bml0dGVzdHMvVjJsa1oyVjBWR1Z6ZEM1RVpYTjBjbTk1WldSWGFYUm9RMkZ3ZEhWeVpWWnBZVVYyWlc1MFRXOXVhWFJ2Y2c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WidgetTest.DestroyedWithCaptureViaEventMonitor&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ8Y2hyb21pdW0ubWVtb3J5L01hYyBBU2FuIDY0IFRlc3RzICgxKS80NTE4Ny92aWV3c191bml0dGVzdHMvVjJsa1oyVjBWR1Z6ZEM1RVpYTjBjbTk1WldSWGFYUm9RMkZ3ZEhWeVpWWnBZVVYyWlc1MFRXOXVhWFJ2Y2c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Hi msw@ it looks like https://chromium-review.googlesource.com/c/chromium/src/+/1258217 is causing this flake. Can you please take a look? Thanks!
Yes, I'll take a look now, thanks.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b79d4760a300c1cd538421fa1916fb52a7b69949 commit b79d4760a300c1cd538421fa1916fb52a7b69949 Author: Mike Wasserman <msw@chromium.org> Date: Tue Oct 16 18:28:44 2018 Fix WidgetTest.DestroyedWithCaptureViaEventMonitor flaky crash ClosingView is destroyed during its call to Widget::CloseNow(). ClosingView::widget_ should not be accesses after calling CloseNow(). Bug: 895882 Test: No flaky crashes Change-Id: I40bb3306e969332191fc7118a905eee5900f0f2e Reviewed-on: https://chromium-review.googlesource.com/c/1283690 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600055} [modify] https://crrev.com/b79d4760a300c1cd538421fa1916fb52a7b69949/ui/views/widget/widget_unittest.cc
Builds 45196 through 45210 passed, so hopefully my fix was sufficient: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29?limit=50 I'll check again in the morning and re-open if I see another failure.
Comment 1 by anthonyvd@chromium.org
, Oct 16Status: Assigned (was: Untriaged)