Extensions: Remove webstore from the features files |
||||||
Issue descriptionWe should remove the "webstore" entry in the features files, so that chrome.webstore is no longer defined. Since the C++ is gone, it wouldn't work anyway, but we shouldn't be exposing the object in JS at all. This will be a small targeted patch that can be merged to M71.
,
Oct 19
This should be fixed. Requesting merge to M71. This is a small, isolated change that should be safe. I'll wait 24 hours before merging to make sure nothing crops up.
,
Oct 19
(wrong merge label)
,
Oct 19
Approving merge to M71 branch 3578 based on comment #2. Pls merge your change to M71 branch #3578 by Monday morning PT (if change looks good in canary) so we can pick it up for next M71 Beta release. Thank you.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff20d4a876f72f5cdda59e75544f62aa85f74380 commit ff20d4a876f72f5cdda59e75544f62aa85f74380 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Oct 19 22:43:58 2018 [M71][Extensions] Remove the webstore API feature The chrome.webstore API is used (exclusively) for inline install, which is deprecated and to be removed in M71. [1] Remove the webstore entry from the extensions features files; this will result in chrome.webstore being undefined for all JS contexts. [1] https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 895868 TBR=rdevlin.cronin@chromium.org (cherry picked from commit 0d2282fa4c56aa7cef16b58c1fac6777874fbdc8) Change-Id: Idce382e5dd967a22ba779204d63e1ec509493ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1283485 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600906} Reviewed-on: https://chromium-review.googlesource.com/c/1292394 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#175} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/ff20d4a876f72f5cdda59e75544f62aa85f74380/chrome/common/extensions/api/_api_features.json [modify] https://crrev.com/ff20d4a876f72f5cdda59e75544f62aa85f74380/extensions/renderer/extension_bindings_system.cc [modify] https://crrev.com/ff20d4a876f72f5cdda59e75544f62aa85f74380/extensions/renderer/extension_bindings_system.h
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff20d4a876f72f5cdda59e75544f62aa85f74380 Commit: ff20d4a876f72f5cdda59e75544f62aa85f74380 Author: rdevlin.cronin@chromium.org Commiter: rdevlin.cronin@chromium.org Date: 2018-10-19 22:43:58 +0000 UTC [M71][Extensions] Remove the webstore API feature The chrome.webstore API is used (exclusively) for inline install, which is deprecated and to be removed in M71. [1] Remove the webstore entry from the extensions features files; this will result in chrome.webstore being undefined for all JS contexts. [1] https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 895868 TBR=rdevlin.cronin@chromium.org (cherry picked from commit 0d2282fa4c56aa7cef16b58c1fac6777874fbdc8) Change-Id: Idce382e5dd967a22ba779204d63e1ec509493ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1283485 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600906} Reviewed-on: https://chromium-review.googlesource.com/c/1292394 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#175} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Oct 18