New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895857 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
please use my google.com address
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

linux_chromeos_rel is compiling _android.cc files?!

Project Member Reported by gab@chromium.org, Oct 16

Issue description

I just got a compile error :

  FAILED: android_clang_x86/obj/base/base/platform_thread_android.o 
  /b/swarming/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF android_clang_x86/obj/base/base/platform_thread_android.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_GNU_SOURCE -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION_ROLL=r16_1 -DCR_CLANG_REVISION=\"344066-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DCHROMIUM_CXX_TWEAK_INLINES -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBASE_IMPLEMENTATION -I../.. -Iandroid_clang_x86/gen -Iandroid_clang_x86/gen/base/base_jni_headers -Iandroid_clang_x86/gen/base/base_jni_headers/base -Iandroid_clang_x86/gen/base/android_runtime_jni_headers/base -I../../third_party/android_ndk/sources/android/cpufeatures -fno-strict-aliasing --param=ssp-buffer-size=4 -fno-stack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -ffunction-sections -fno-short-enums --target=i686-linux-android -isystem../../third_party/android_ndk/sysroot/usr/include/i686-linux-android -D__ANDROID_API__=16 -DHAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -m32 -msse2 -mfpmath=sse -mmmx -momit-leaf-frame-pointer -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -Wno-defaulted-function-deleted -fno-omit-frame-pointer -g0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-char-subscripts -Wglobal-constructors -Wexit-time-destructors -Wshadow -Wexit-time-destructors -O2 -fno-ident -fdata-sections -ffunction-sections -std=c++14 -fno-exceptions -fno-rtti --sysroot=../../third_party/android_ndk/sysroot -isystem../../third_party/android_ndk/sources/cxx-stl/llvm-libc++/include -isystem../../third_party/android_ndk/sources/cxx-stl/llvm-libc++abi/include -isystem../../third_party/android_ndk/sources/android/support/include -fvisibility-inlines-hidden -c ../../base/threading/platform_thread_android.cc -o android_clang_x86/obj/base/base/platform_thread_android.o
  ../../base/threading/platform_thread_android.cc:56:10: error

On https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/117760

...?!


GN args on that bot are :

dcheck_always_on = true
ffmpeg_branding = "ChromeOS"
is_component_build = false
is_debug = false
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 0
target_os = "chromeos"
use_goma = true
use_vaapi = true
goma_dir = "/b/swarming/w/ir/cache/goma/client"

Specifically "target_os = "chromeos""; why does that compile android files?!

@chromeos/OWNERS for triage
 
Cc: dpranke@google.com steve...@chromium.org llozano@chromium.org khmel@chromium.org bhthompson@google.com
Components: -Build Infra>Client>ChromeOS>Build Platform>Apps>ARC
Owner: ----
I'm not sure why I got assigned this. Perhaps because of Arc++ we include _android.cc files in one or more chromeos targets?

Here is the patch for others convenience:
https://chromium-review.googlesource.com/c/chromium/src/+/1283021/5


Components: -Infra>Client>ChromeOS>Build
CrOS build team isn't responsible for chromium/src/ code.  that's all browser land.
Could you please help us find the correct component so that this can be triaged????????

Cc: dcheng@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
I think some chunk of the android code is needed for ARC++ and Mojo compatibility, but I'm not sure if stuff in base is part of it (that'd be a bit surprising).

@rockot, dcheng - can you take a look?
Yes, we build some libraries against the Android toolchain on Chrome OS builds. This means is_android is true for those targets. It's intentional.
Status: WontFix (was: Assigned)
Ah ok, sorry for the noise then, I was just super confused by this...

Sign in to add a comment