Remove white space in FIP will remove the white space from the web page article |
|||
Issue descriptionApp Version: 72.0.3582.0 Canary iOS Version: 10.3.3, 11.4.1, 12.0, 12.1 beta Device: iPhone, iPad Steps to reproduce: 1. Launch chrome 2. Load any news article 3. Open Find in page and enter a white space 4. And remove the white space using clear button in keyboard Observed results: Notice that some of the white space in the article are removed Expected results: White space in the article is shouldn’t be removed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: No, Safari: No Bug reproducible on current stable build (App Version, iOS Version): NA on M69 (FIP doesn’t support white space no results shown http://crbug/228580) Bug reproducible on the current beta channel build (App Version, iOS Version): No on M70 Beta and Yes on M71 (71.0.3578.9) Beta Link to video: https://drive.google.com/file/d/1lCNOglJfPbNWPQA85gYj3mvZh3Nsgxwp/view?usp=sharing
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e7272dd513b74ccbfef3a7d488baa8db95a2cf5 commit 7e7272dd513b74ccbfef3a7d488baa8db95a2cf5 Author: Yi Su <mrsuyi@chromium.org> Date: Wed Nov 21 16:02:12 2018 Introduce Replacement class in find_in_page.js to do DOM operations for highlighting search results in a better way. This CL introduces the Replacement class into find_in_page.js to support better DOM operations for highlighting search results. This will fix the bug that whitespaces are reduced when users search for a single whitespace and cancel the search. This CL is also a necessary preliminary work for supporting searching across multiple HTML nodes. Bug: 228585, 895839 Change-Id: I960a012daef93824039ff22b824f70dcc6d1e3b7 Reviewed-on: https://chromium-review.googlesource.com/c/1341918 Reviewed-by: Eric Noyau <noyau@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610085} [modify] https://crrev.com/7e7272dd513b74ccbfef3a7d488baa8db95a2cf5/ios/chrome/browser/find_in_page/resources/find_in_page.js
,
Nov 21
,
Nov 27
Verified in: App Version: 72.0.3622.0 canary Devices: iPad Mini, iPhoneX, iPhone 7 Plus iOS Versions: 11.4.1,12.0.1,12.1 Removing white space in FIP doesn't remove the space from the web article |
|||
►
Sign in to add a comment |
|||
Comment 1 by linds...@chromium.org
, Oct 17Labels: ReleaseBlock-Stable M-72
Owner: mrsuyi@chromium.org
Status: Assigned (was: Untriaged)