New issue
Advanced search Search tips

Issue 895832 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

CrElementsInputTest.All is flaky on linux-chromeos-rel

Project Member Reported by cfroussios@chromium.org, Oct 16

Issue description

Components: UI>Browser>WebUI
Labels: OS-Chrome
Cc: dpa...@chromium.org
Owner: rbpotter@chromium.org
Status: Assigned (was: Available)
Assigning to the only owner of chrome/test/data/webui/
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e4fb8c425c159ecfad003055488560fdd81b03d

commit 3e4fb8c425c159ecfad003055488560fdd81b03d
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Oct 16 14:46:53 2018

Disable CrElementsInputTest.All on ChromeOS

The test is 50% flaky.

TBR=rbpotter@chromium.org

Bug: 895832
Change-Id: Ic97a551542ae757c10e81a2440454b213aa05f05
Reviewed-on: https://chromium-review.googlesource.com/c/1282959
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599978}
[modify] https://crrev.com/3e4fb8c425c159ecfad003055488560fdd81b03d/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js

Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddf49ee281d3dd2c256887cb9d30b80050bd96db

commit ddf49ee281d3dd2c256887cb9d30b80050bd96db
Author: Joe Downing <joedow@chromium.org>
Date: Thu Oct 18 18:20:03 2018

Fixing an incorrect OS macro

This was causing the flaky test to continue to run even though it
seemed like it was disabled.

TBR=cfroussios@chromium.org
Bug=895832

Change-Id: Iedb9e4439f9f7ed2fce88692e94f12a0195ef6f0
Reviewed-on: https://chromium-review.googlesource.com/c/1288907
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600830}
[modify] https://crrev.com/ddf49ee281d3dd2c256887cb9d30b80050bd96db/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fe8ad719ea0aa4a5b94a320d4ace4c06b593ef1

commit 9fe8ad719ea0aa4a5b94a320d4ace4c06b593ef1
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 09 17:40:38 2019

CrElementsInputTest: Fix flakiness on Chrome OS

Test was ~50% flaky (reproduced failure locally). With fix, test passed
100% of the time with gtest_repeat=20.

Bug: 895832
Change-Id: Ibd997ecf24f5d645bcdeb36628f0d77512c37baf
Reviewed-on: https://chromium-review.googlesource.com/c/1401447
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621206}
[modify] https://crrev.com/9fe8ad719ea0aa4a5b94a320d4ace4c06b593ef1/chrome/test/data/webui/cr_elements/cr_elements_focus_test.js
[modify] https://crrev.com/9fe8ad719ea0aa4a5b94a320d4ace4c06b593ef1/chrome/test/data/webui/cr_elements/cr_input_test.js

Sign in to add a comment