settings-slider component's "disabled" flag doesn't work with "ticks" |
||||
Issue description
Chrome Version: 72
"disabled" flag doesn't work properly when using <settings-slider> component. Component is disabled correctly if I use "min", "max" and "scale" instead of "ticks". But if I use "ticks" component is re-enabled on each ticks change.
Example of code:
<settings-slider id="displaySizeSlider"
ticks="[[zoomValues_]]"
disabled$="[[!prefs.ash.night_light.enabled.value]]"
label-min="$i18n{displaySizeSliderMinLabel}"
label-max="$i18n{displaySizeSliderMaxLabel}"
on-value-changed="onDisplaySizeSliderDrag_">
</settings-slider>
Code is taken from https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display.html?type=cs&q=display.html&g=0&l=149
just the "disabled" flag was added to the slider.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d7b90a6780a9e78c85adfd2320a7ceb34d758ec commit 2d7b90a6780a9e78c85adfd2320a7ceb34d758ec Author: Esmael El-Moslimany <aee@chromium.org> Date: Tue Oct 23 22:25:48 2018 WebUI: cr-slider, keep public |disabled| unchanged When |ticks.length == 1| or the public |disabled| property is true, the slider is effectively disabled. Bug: 895831 Change-Id: Iea13afaec1b784a433fd9f7fa8fe9d7a98a531b9 Reviewed-on: https://chromium-review.googlesource.com/c/1284090 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602135} [modify] https://crrev.com/2d7b90a6780a9e78c85adfd2320a7ceb34d758ec/chrome/test/data/webui/cr_elements/cr_slider_test.js [modify] https://crrev.com/2d7b90a6780a9e78c85adfd2320a7ceb34d758ec/ui/webui/resources/cr_elements/cr_slider/cr_slider.html [modify] https://crrev.com/2d7b90a6780a9e78c85adfd2320a7ceb34d758ec/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
,
Oct 23
,
Oct 24
Seems to work. Thanks for the quick fix!
,
Oct 24
|
||||
►
Sign in to add a comment |
||||
Comment 1 by aee@chromium.org
, Oct 16