New issue
Advanced search Search tips

Issue 895825 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-03-01
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove the kMaxAppCacheDiskCacheSizeMb and kMaxAppCacheOriginCacheSizeMb

Project Member Reported by gyuyoung...@chromium.org, Oct 16

Issue description

According to the consensus in  bug 824619  and  bug 892547 , we will remove kMaxAppCacheDiskCacheSizeMb and kMaxAppCacheOriginCacheSizeMb switches when overall quota limitation is ready.
 
Cc: pwnall@chromium.org
Labels: -Pri-3 Pri-2
NextAction: 2019-03-01
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6efb4dae8ab5d42f5ffcd9b9185c3b7af72925e5

commit 6efb4dae8ab5d42f5ffcd9b9185c3b7af72925e5
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Sat Nov 03 01:27:17 2018

AppCache: Add command-line flags for default quota and disk size.

This CL introduces the following command-line switches:
- max-appcache-disk-cache-size-mb - limits the size of the HTTP disk
  cache used by AppCache for all origins
- max-appcache-origin-cache-size-mb - limits the per-origin AppCache
  quota when no QuotaManager is present

The CL is heavily based on the following reverted commits:
1. https://crrev.com/c/974804 - Set the maximum cache size per an origin
    in the command line for application cache
2. https://crrev.com/c/979877 - Pass the maximium disk cache size of
    appcache in the command line to appcache thread

Bug:  824619 , 895825
Change-Id: I4fb424fa740ef9875d0584def4e9390aef366916
Reviewed-on: https://chromium-review.googlesource.com/c/1282685
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#605118}
[modify] https://crrev.com/6efb4dae8ab5d42f5ffcd9b9185c3b7af72925e5/content/browser/appcache/appcache_storage_impl.cc
[modify] https://crrev.com/6efb4dae8ab5d42f5ffcd9b9185c3b7af72925e5/content/public/common/content_switches.cc
[modify] https://crrev.com/6efb4dae8ab5d42f5ffcd9b9185c3b7af72925e5/content/public/common/content_switches.h

Cc: gyuyo...@igalia.com

Sign in to add a comment