New issue
Advanced search Search tips

Issue 895819 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add credential provider unit test to the chrome builtboys

Project Member Reported by rogerta@chromium.org, Oct 16

Issue description

The credential provider unit tests are in the binary gcp_unittests.exe.  Make sure this execute runs in trybots and the CQ.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e73edc2343800d19cd1474b7cd5da39571089d8

commit 4e73edc2343800d19cd1474b7cd5da39571089d8
Author: Roger Tawa <rogerta@chromium.org>
Date: Tue Oct 16 16:16:39 2018

Reland: Add credential provider unit tests run on the buildbots.

Fix up the tests so that they run correctly with base::LaunchUnitTests().
Add the unit test exe to the buildbot configs.

The original CL was reverted by:
https://chromium-review.googlesource.com/c/chromium/src/+/1281880

patchset 1 of this CL contains the unmodified change that originally broken
the build.  Further patchset contain the corrections.

Bug:  895819 
Change-Id: Idad19d89192df4fdf11dc8def75709322bfd9c31
Reviewed-on: https://chromium-review.googlesource.com/c/1283255
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600007}
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/gaiacp/dllmain.cc
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/gaiacp/gaia_credential_provider_module.h
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/gaiacp/gcp_utils_unittests.cc
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/gaiacp/reauth_credential_unittests.cc
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/test/BUILD.gn
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/chrome/credential_provider/test/gcp_test_main.cc
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/chromium.win.json
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/4e73edc2343800d19cd1474b7cd5da39571089d8/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)

Sign in to add a comment