New issue
Advanced search Search tips

Issue 895784 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

'git cl status' fails with NotImplementedError

Project Member Reported by neis@google.com, Oct 16

Issue description

Today suddenly 'git cl status' stopped working.

~/v8$ git cl status
Branches associated with reviews:
Traceback (most recent call last):
  File "/usr/local/google/home/neis/tools/depot_tools/metrics.py", line 225, in print_notice_and_exit
    yield
  File "/usr/local/google/home/neis/tools/depot_tools/git_cl.py", line 6013, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/neis/tools/depot_tools/git_cl.py", line 5995, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/neis/tools/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/neis/tools/depot_tools/git_cl.py", line 4380, in CMDstatus
    c, status = output.next()
  File "/usr/local/google/home/neis/tools/depot_tools/git_cl.py", line 4095, in get_cl_statuses
    cl.EnsureAuthenticated(force=False, refresh=True)
  File "/usr/local/google/home/neis/tools/depot_tools/git_cl.py", line 1954, in EnsureAuthenticated
    raise NotImplementedError
NotImplementedError
 
Cc: tandrii@chromium.org
Owner: tandrii@chromium.org
Status: Started (was: Untriaged)
Right, that's because you have old Rietveld branches around.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/51bdf8c8dda4b8861e50be686fb3847606deba07

commit 51bdf8c8dda4b8861e50be686fb3847606deba07
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Oct 18 01:07:58 2018

Reland "git cl: delete no longer used Rietveld methods."

This is a reland of 38d36a616db2bfd86379225cc45c981f89161ced
but now
 $ git cl status
 $ git cl archive
actually work.

Original change's description:
> git cl: delete no longer used Rietveld methods.
>
> R=ehmaldonado
>
> Bug: 770408
> Change-Id: I4dc034839180a7587ee368793547c5b74c2572f6
> Reviewed-on: https://chromium-review.googlesource.com/c/1279139
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 770408,  895784 
Change-Id: Id1dbf31dc19d693f1c4636c9558e1ac99fe6a77b
Reviewed-on: https://chromium-review.googlesource.com/c/1287245
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/51bdf8c8dda4b8861e50be686fb3847606deba07/git_cl.py

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e

commit 3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 18 04:38:04 2018

Roll src/third_party/depot_tools 08faab99d41b..488362624b6d (5 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/08faab99d41b..488362624b6d


git log 08faab99d41b..488362624b6d --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ehmaldonado@chromium.org metrics: Add a mechanism to notify users when we want to collect additional metrics.
2018-10-18 tandrii@chromium.org git cl land: remove Rietveld-only options.
2018-10-18 tandrii@chromium.org Reland "git cl: delete no longer used Rietveld methods."
2018-10-18 ehmaldonado@chromium.org Use lowercase machine architecture.
2018-10-17 jbudorick@chromium.org bot_update: stop failing with a KeyError in the recipe on failure.


Created with:
  gclient setdep -r src/third_party/depot_tools@488362624b6d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:770408,chromium:770408,chromium:895784,chromium:896355
TBR=agable@chromium.org

Change-Id: I0a0fc6c3a5b488b1480c808f4b0d2f5d791cfa38
Reviewed-on: https://chromium-review.googlesource.com/c/1288015
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600659}
[modify] https://crrev.com/3fdee98c1c33b01fcfe216f15e73d991d3bc1d1e/DEPS

Sign in to add a comment