[wpt import] content_shell crashes on reftests with href=about:blank when run via r-w-t |
||
Issue descriptionhttps://github.com/web-platform-tests/wpt/pull/13489 added this new test, which is currently causing a DCHECK to be hit on Mac and Linux and preventing new imports from being merged. Running content_shell manually works fine: I've only been able to reproduce the crash if I run run_web_tests.py. Backtrace: 12:06:35.282 21272 #0 0x7f9900fbba3d base::debug::StackTrace::StackTrace() 12:06:35.282 21272 #1 0x7f9900c9070a base::debug::StackTrace::StackTrace() 12:06:35.282 21272 #2 0x7f9900cc179b logging::LogMessage::~LogMessage() 12:06:35.283 21272 #3 0x7f9900ca3074 base::FilePath::Append() 12:06:35.283 21272 #4 0x7f9900ca5fe0 base::FilePath::Append() 12:06:35.283 21272 #5 0x000001a9b455 content::(anonymous namespace)::GetTestInfoFromLayoutTestName() 12:06:35.283 21272 #6 0x000001a99f0c content::TestInfoExtractor::GetNextTest() 12:06:35.283 21272 #7 0x000001a8504c (anonymous namespace)::RunTests() 12:06:35.283 21272 #8 0x000001a3f0dd LayoutTestBrowserMain() 12:06:35.283 21272 #9 0x000001a3e990 content::ShellMainDelegate::RunProcess() 12:06:35.283 21272 #10 0x7f98fef403fa content::RunBrowserProcessMain() 12:06:35.283 21272 #11 0x7f98fef43267 content::ContentMainRunnerImpl::Run() 12:06:35.283 21272 #12 0x7f98fef3915c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() 12:06:35.283 21272 #13 0x7f98da14cc2a service_manager::Main() 12:06:35.284 21272 #14 0x7f98fef3db53 content::ContentMain() 12:06:35.284 21272 #15 0x0000008ee165 main 12:06:35.284 21272 #16 0x7f98dab98fea __libc_start_main 12:06:35.284 21272 #17 0x0000008ee02a _start CI backtrace: https://test-results.appspot.com/data/layout_results/mac_chromium_rel_ng/163332/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html It's also important to note that even when DCHECKs are disabled (such as in the Blink trybots), the results aren't the ones we expect: the runner treats it like a pixel test and the failure results contain a listing of the bot's filesystem... See https://test-results.appspot.com/data/layout_results/linux-blink-rel/1266/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html for example.
,
Oct 31
Retitling since this is a more general issue -- the imports are currently blocked because of a similar crash introduced by https://github.com/web-platform-tests/wpt/pull/13487. See e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/174841
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a37720b623f7f52363469241ff136b07ad8eaeb5 commit a37720b623f7f52363469241ff136b07ad8eaeb5 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Oct 31 12:01:44 2018 Mark upcoming text-perspective-001.html test as crashing/passing This test was added in https://github.com/web-platform-tests/wpt/pull/13487, and triggers the same content_shell crash we had a while ago when a reftest has <link href="about:blank">. Mark it as both passing and crashing to allow imports to continue. TBR=lukebjerring Bug: 895777 No-Try: True Change-Id: I9cee89e8ff67e3c83414a73bb18cb7d74c5d6c06 Reviewed-on: https://chromium-review.googlesource.com/c/1309779 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#604218} [modify] https://crrev.com/a37720b623f7f52363469241ff136b07ad8eaeb5/third_party/WebKit/LayoutTests/TestExpectations |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 16