Issue metadata
Sign in to add a comment
|
Regression: PiP window closes unexpectedly on tap-touch.
Reported by
aiman.an...@etouch.net,
Oct 16
|
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3538.67 (Official Build) Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002} (32/64 Bit). OS: Windows 10 (Touch Device). Test URL: https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html Steps to reproduce: 1. Launch chrome, Navigate to the above URL. 2. Using tap-touch to open Picture-in-Picture window. 3. Using tap-touch press play button in parent window and pause the video after 0:1-0:2 seconds. 4. Now tap-touch on PiP window and observe. (Kindly refresh the page and again perform steps 2-3 times to reproduce issue, as issue is not seen on first instance.) Actual Result: PiP window closes unexpectedly on tap-touch. Expected Result: PiP window should not close on tap-touch. This is Regression Issue broken in M-70, and below is the manual bisect info. Good Build: 70.0.3535.0 (Revision:586475) Bad Build: 70.0.3536.0 (Revision:587136) Narrow Bisect: CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/70.0.3535.0..70.0.3536.0?pretty=fuller&n=10000 Suspecting: r586965 ? apacible @: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is Win 10 (Touch Device) specific and is not seen on Win(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS) OS. 2. Unable to provide 'per-revision' bisect as it shows Traceback Error 3. Unable to provide Chromium bisect, as issue is not reproducible on chromium builds. Hence providing suspect manually. 4. Issue is also seen on Beta #70.0.3538.54, Dev #71.0.3573.0 and Canary #72.0.3581.0 build. 5. Issue is seen for all PiP related experiments. Kindly refer the attached screen-cast. Thank You!
,
Oct 25
,
Nov 1
,
Nov 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb83de09f2c986ee91741f3a2776feea0e18e3f6 commit fb83de09f2c986ee91741f3a2776feea0e18e3f6 Author: Tommy Steimel <steimel@chromium.org> Date: Sat Nov 10 00:04:06 2018 Revert "[Picture in Picture] Call parent function in OnGestureEvent." This reverts commit e60d9aef9d1eeeff4e5954ba137ed5009261f626. Reason for revert: Causes the close button to receive gesture events even when it's not the target of the tap. This causes the PiP window to unexpectedly close. Bug: 895773 Original change's description: > [Picture in Picture] Call parent function in OnGestureEvent. > > Change-Id: I854654be22abd217c3f8ed557bc3fb9118c557c6 > Reviewed-on: https://chromium-review.googlesource.com/1192326 > Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> > Commit-Queue: apacible <apacible@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586820} # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I2f36d78713f0b811a0a2681e09284c394e146a5c Reviewed-on: https://chromium-review.googlesource.com/c/1318397 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#607039} [modify] https://crrev.com/fb83de09f2c986ee91741f3a2776feea0e18e3f6/chrome/browser/ui/views/overlay/overlay_window_views.cc
,
Nov 12
Update: Retested the above issue on Win 10(Touch Device) using latest Canary build #72.0.3608.0 and issue is fixed. Now, PiP window does not close unexpectedly on tap-touch. Kindly refer the attached screen-cast. Thank you!
,
Nov 12
Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fbeaufort@chromium.org
, Oct 16Owner: ----
Status: Available (was: Assigned)