New issue
Advanced search Search tips

Issue 895772 link

Starred by 2 users
Status: Fixed
Owner:
blundell@chromium.org
Closed: Oct 22
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 882865
Blocking:
issue 883318
issue 883330



Sign in to add a comment

Port IdentityTestEnvironmentProfileAdaptor to //ios/chrome

Project Member Reported by blundell@chromium.org, Oct 16 
At some point ChromeBrowserState-based unittests in //ios/chrome will need to be ported to interact with IdentityManager. To facilitate this porting, we should port IdentityTestEnvironmentProfileAdaptor to //ios/chrome as IdentityTestEnvironmentBrowserStateAdaptor. In turn, we will first need to enable using FakeGaiaCookieManagerService in //ios/chrome, where it is currently not used (and there is no equivalent of //chrome's fake_gaia_cookie_manager_service_builder.h). This work theoretically should be straightforward.

Comment 1 by blundell@chromium.org, Oct 19

Owner: blundell@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1336f277af79a38c09b626df28c82a9e2a2da05d

commit 1336f277af79a38c09b626df28c82a9e2a2da05d
Author: Colin Blundell <blundell@chromium.org>
Date: Fri Oct 19 15:12:26 2018

Add ios/chrome FakeGaiaCookieManagerService builder

Will shortly be needed by an //ios/chrome port of
IdentityTestEnvironmentProfileAdaptor.

Bug:  895772 
Change-Id: Icb7478cfc51d6bd7f6061eeab5d1ced66fe1e1a7
Reviewed-on: https://chromium-review.googlesource.com/c/1290954
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601155}
[modify] https://crrev.com/1336f277af79a38c09b626df28c82a9e2a2da05d/ios/chrome/browser/signin/BUILD.gn
[add] https://crrev.com/1336f277af79a38c09b626df28c82a9e2a2da05d/ios/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
[add] https://crrev.com/1336f277af79a38c09b626df28c82a9e2a2da05d/ios/chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae423e5333302ab48bfe191e56d44f434a413715

commit ae423e5333302ab48bfe191e56d44f434a413715
Author: Colin Blundell <blundell@chromium.org>
Date: Fri Oct 19 17:12:16 2018

[ios] Provide ChromeBrowserState IdentityTestEnvironment adaptor

A straightforward port of //chrome's Profile adaptor that will be used
by //ios/chrome unittests that tied to the
BrowserStateKeyedServiceFactory infrastructure.

Bug:  895772 
Change-Id: I61cd90a0fdcb494e661711ccfb8c2bdeb411193d
Reviewed-on: https://chromium-review.googlesource.com/c/1290941
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601198}
[modify] https://crrev.com/ae423e5333302ab48bfe191e56d44f434a413715/ios/chrome/browser/signin/BUILD.gn
[add] https://crrev.com/ae423e5333302ab48bfe191e56d44f434a413715/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.cc
[add] https://crrev.com/ae423e5333302ab48bfe191e56d44f434a413715/ios/chrome/browser/signin/identity_test_environment_chrome_browser_state_adaptor.h
[modify] https://crrev.com/ae423e5333302ab48bfe191e56d44f434a413715/services/identity/public/cpp/identity_test_environment.h

Comment 4 by blundell@chromium.org, Oct 22

Status: Fixed (was: Started)
►

Sign in to add a comment