New issue
Advanced search Search tips

Issue 895769 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Oct 24
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Print]All print options appear disabled after selecting 'Save as PDF' when signed in to chrome

Reported by vineetha...@etouch.net, Oct 16 
Chrome Version: 70.0.3538.67 (Official Build) Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}(32/64-bit)
OS: Windows (7, 8, 8.1 ,10)

Pre-condition: Fresh launch chrome and enable the flag 'Enable new Print Preview UI' under chrome://flags

What steps will reproduce the problem?
1. On fresh launch ,Press (Ctrl + P) to open Print Preview overlay.
2. Click on 'Change' button to open 'Select a destination' overlay.
3. Now click on 'Sign in' link present on the overlay and Sign in to chrome.
4. Then click on 'Save as PDF' option under 'Print Destinations' and observe.

Actual Result  : All print options appear disabled after selecting 'Save as PDF'.
Expected Result: Print options should remain enabled after selecting 'Save as PDF'.

This is a regression issue broken in ‘M-69’ and below is the 'per-revision' bisect information:
Good Build : 69.0.3495.0 (Revision : 575927)
Bad Build  : 69.0.3496.0 (Revision : 576216)

You are probably looking for a change made after 575961 (known good), but no later than 575962 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.  

https://chromium.googlesource.com/chromium/src/+log/ec103cf08c0604aedb183f97dd8a11ea6a489e22..fcd7852fe04f763552fe289d4ff6881e241dff6d

Suspect: https://chromium.googlesource.com/chromium/src/+/fcd7852fe04f763552fe289d4ff6881e241dff6d

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast.

Note: 
1. Issue is specific to Windows OS.
2. Issue is also seen on Beta build #70.0.3538.54, Dev build #71.0.3573.0 and latest Canary build #72.0.3581.0
3. Issue is reproducible only on fresh launch.

Thank you
ActualVideo.mp4
1.2 MB View Download
ExpectedVideo.mp4
1.1 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec27b0ad70849d244e34340be27fb92819cead1e

commit ec27b0ad70849d244e34340be27fb92819cead1e
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Oct 23 19:30:28 2018

Print Preview Refresh: Fix Save as PDF bug

Print Preview's destination and capabilities update process works as
follows:
(1) The destination associated with the destination-list-item selected
by the user is sent to the destination store. Call this
item-destination.
(2) destination store sets |selectedDestination_| to the destination
in its destinations map that has a matching key to item-destination,
and requests capabilities for item-destination.
(3) When capabilities are returned from the handler, the store updates
|selectedDestination_| if item-destination, the destination for which
they were retrieved, matches |selectedDestination_|.
(4) This update transitions the UI to a ready state.

When the user signs in successfully, the destinations map is completely
reset. The Save as PDF destination is recreated just after reset and
the recreated Save as PDF printer is added to the map. However, this
was not triggering an update to the destination associated with the
destination-list-item displaying the Save as PDF printer, because the
new Save as PDF destination has all the same properties as the old one.
As a result, if this destination was selected, the capabilities were
retrieved for the old Save as PDF destination, while the
|selectedDestination_| was the new destination. This mismatch caused
the destination update event to never be fired, so the UI was stuck
in a non-ready state.

This CL forces the destination list used by the destination-list-items
to update when the destination store updates its map, which ensures
the list item for the Save as PDF printer gets the updated Save as PDF
destination from the destination store's map.

Bug:  895769 
Change-Id: I1052609eddb2c240ece4e3132b829fb6b10ef35c
Reviewed-on: https://chromium-review.googlesource.com/c/1284708
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602053}
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/browser/resources/print_preview/data/destination_store.js
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/browser/resources/print_preview/new/destination_dialog.js
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/browser/resources/print_preview/new/destination_settings.js
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/test/data/webui/print_preview/destination_dialog_test.js
[modify] https://crrev.com/ec27b0ad70849d244e34340be27fb92819cead1e/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js

Comment 2 by rbpotter@chromium.org, Oct 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment