New issue
Advanced search Search tips

Issue 895766 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Reenable ToolbarContainerViewControllerTest.* on device

Project Member Reported by olivierrobin@chromium.org, Oct 16

Issue description

Test are consistently failing on iPhoneX iOS 11.4.1 (release).
Disabling the tests on device.
 
Status: Started (was: Assigned)
crrev.com/c/1285113
Labels: OS-iOS
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343f58e4df9cefa7be327d3fd8419d7276f1d837

commit 343f58e4df9cefa7be327d3fd8419d7276f1d837
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Thu Oct 18 21:04:33 2018

[iOS] Fix toolbar container progress logic.

The previous implementation of ToolbarContainer scaled
each toolbar's interpolation progress at the same rate,
resulting in accordion-like behavior where all toolbars
were expanded and collapsed at the same time.  The desired
effect is to have telescopic behavior, where the toolbars
are extended one at a time.  This is needed on iPad, where
a scroll event should first reduce the height of the tab
strip to 0.0 before reducing the height of the primary
toolbar.

This CL adds logic to convert the [0.0, 1.0] fullscreen
progress range for the overall stack to individual progress
values for each toolbar, such that the last toolbar is
expanded first, and the previous toolbars don't start
expanding until all subsequent ones are fully expanded.
The range of stack-level progress values corresponding to
a particular toolbar is proportional to that toolbar's
height delta relative to the height delta of the overall
stack.

In addition, this CL also introduces HeightRange, a simple
container object that can be used to hold max and min heights
and perform interpolation calculations.

Bug: 880672,  895766 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1205ec75ac3e9a0e57dc19d1ebcc1f1740f8aeac
Reviewed-on: https://chromium-review.googlesource.com/c/1231933
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600903}
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/BUILD.gn
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/collapsing_toolbar_height_constraint.h
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/collapsing_toolbar_height_constraint.mm
[add] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/collapsing_toolbar_height_constraint_delegate.h
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/collapsing_toolbar_height_constraint_unittest.mm
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_container_coordinator.mm
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.h
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller.mm
[modify] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_container_view_controller_unittest.mm
[add] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_height_range.h
[add] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_height_range.mm
[add] https://crrev.com/343f58e4df9cefa7be327d3fd8419d7276f1d837/ios/chrome/browser/ui/toolbar_container/toolbar_height_range_unittest.mm

Status: Fixed (was: Started)
Tests removed in crrev.com/c/1231933

Sign in to add a comment