Issue metadata
Sign in to add a comment
|
gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests is flaky on chromium.gpu/Win10 Debug (NVIDIA) |
||||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of cfroussios@chromium.org gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests failing on chromium.gpu/Win10 Debug (NVIDIA) Builders failed on: - Win10 Debug (NVIDIA): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29 Failure example https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/8736
,
Oct 16
Disabling the test with https://chromium-review.googlesource.com/c/chromium/src/+/1267235
,
Oct 16
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9780253fa75f648aea3070fa2079e1f314d33f48 commit 9780253fa75f648aea3070fa2079e1f314d33f48 Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Oct 16 14:34:12 2018 Disable ContextLost_WebGLUnblockedAfterUserInitiatedReload gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests is flaky on Win10 Debug TBR=kbr@chromium.org Bug: 895765 , 879423 Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6 Reviewed-on: https://chromium-review.googlesource.com/c/1283049 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#599973} [modify] https://crrev.com/9780253fa75f648aea3070fa2079e1f314d33f48/content/test/gpu/gpu_tests/context_lost_expectations.py
,
Oct 16
The test failures were caused by a crash in cc: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Debug%20%28NVIDIA%29/8736 https://chromium-swarm.appspot.com/task?id=4094493a76ef5a10&refresh=10&show_raw=1 Stack Trace: ******************************************************************************** Last event: 1160.1b74: Access violation - code c0000005 (first/second chance not available) debugger time: Mon Oct 15 23:05:01.906 2018 (UTC - 7:00) ChildEBP RetAddr Args to Child 1377e108 5d7f854c 1377e154 5d7f08a0 1377e13c cc!cc::TileManager::CheckRasterFinishedQueries+0x5d 1377e118 5d7f848f 5d7f08a0 1377e154 1377e154 cc!??$Invoke@P8TileManager@cc@@AEXXZPAV12@$$V@?$FunctorTraits@P8TileManager@cc@@AEXXZX@internal@base@@SAXP8TileManager@cc@@AEXXZ$$QAPAV34@@Z+0x1c 1377e13c 5d7f8425 0ec2da4c 1377e154 0ec2da4c cc!base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall cc::TileManager::*const &)(void),cc::TileManager *>+0x4f 1377e15c 5d7f830f 0ec2da4c 0ec2da50 00000084 cc!base::internal::Invoker<base::internal::BindState<void (__thiscall cc::TileManager::*)(void),base::internal::UnretainedWrapper<cc::TileManager> >,void __cdecl(void)>::RunImpl<void (__thiscall cc::TileManager::*const &)(void),std::tuple<base::internal::UnretainedWrapper<cc::TileManager> > const &,0>+0x55 1377e184 5d62f122 0ec2da38 5d7f82d0 0e9d3310 cc!base::internal::Invoker<base::internal::BindState<void (__thiscall cc::TileManager::*)(void),base::internal::UnretainedWrapper<cc::TileManager> >,void __cdecl(void)>::Run+0x3f 1377e1a0 5d62efbf 0e9d3310 1377e1bc 5d62f411 cc!base::RepeatingCallback<void __cdecl(void)>::Run+0x32 1377e1ac 5d62f411 0ec70d80 5d62efb0 1377e1e0 cc!??$ForwardRepeating@$$V@?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@AAEXXZ+0xf 1377e1bc 5d62f326 5d62efb0 0ec70d80 0ec70d80 cc!??$Invoke@P8?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@AEXXZABV?$WeakPtr@V?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@@3@$$V@?$FunctorTraits@P8?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@AEXXZX@internal@base@@SAXP8?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@12@AEXXZABV?$WeakPtr@V?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@@2@@Z+0x21 1377e1e0 5d62f2ba 0ec70d7c 0ec70d80 0ec70d80 cc!??$MakeItSo@ABQ8?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@AEXXZABV?$WeakPtr@V?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@@3@$$V@?$InvokeHelper@$00X@internal@base@@SAXABQ8?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@12@AEXXZABV?$WeakPtr@V?$CancelableCallbackImpl@V?$RepeatingCallback@$$A6AXXZ@base@@@internal@base@@@2@@Z+0x66 ... Un-duplicating this, blocking on other CLs, and reverting the suppression - the test failure was real, and catching a newly-introduced bug.
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2cfad3bebf1e25258f7a975a45c4c7da3cf3b5d commit e2cfad3bebf1e25258f7a975a45c4c7da3cf3b5d Author: Kenneth Russell <kbr@chromium.org> Date: Tue Oct 16 19:03:51 2018 Revert "Disable ContextLost_WebGLUnblockedAfterUserInitiatedReload" This reverts commit 9780253fa75f648aea3070fa2079e1f314d33f48. Reason for revert: test failure was real, and caused by https://chromium-review.googlesource.com/1267235 , which has since been reverted. Original change's description: > Disable ContextLost_WebGLUnblockedAfterUserInitiatedReload > > gpu_tests.context_lost_integration_test.ContextLostIntegrationTest.ContextLost_WebGLUnblockedAfterUserInitiatedReload in context_lost_tests > is flaky on Win10 Debug > > TBR=kbr@chromium.org > > Bug: 895765 , 879423 > Change-Id: Ic36400494df68f257329e040be2c72f1ad2ec3a6 > Reviewed-on: https://chromium-review.googlesource.com/c/1283049 > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599973} TBR=kbr@chromium.org,cfroussios@chromium.org Change-Id: I33951694d070e6eb183eba9a05d9ea517f81ce65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895765 , 879423 Reviewed-on: https://chromium-review.googlesource.com/c/1283945 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600061} [modify] https://crrev.com/e2cfad3bebf1e25258f7a975a45c4c7da3cf3b5d/content/test/gpu/gpu_tests/context_lost_expectations.py
,
Oct 16
This test should be reliable again.
,
Oct 16
https://chromium-review.googlesource.com/c/chromium/src/+/1283487 is relanding the change here with the bug from the original change fixed. I'll keep an eye as well but if you see the flakiness here return, please feel free to revert the reland.
,
Oct 16
Thanks Khushal.
,
Dec 4
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cfroussios@chromium.org
, Oct 16