SkColorSpace ctor assert |
||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5142648191713280 Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer Job Type: libfuzzer_chrome_asan_debug Platform Id: linux Crash Type: Abrt Crash Address: 0x05390031a143 Crash State: sk_abort_no_print SkColorSpace::SkColorSpace SkColorSpace::SkColorSpace Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=595362:595363 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5142648191713280 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
,
Oct 16
Automatically adding ccs based on OWNERS file / target commit history. If this is incorrect, please add ClusterFuzz-Wrong label.
,
Oct 16
Automatically assigning owner based on suspected regression changelist https://skia.googlesource.com/skia/+/cfa315390f04ebcdfac3569758535aec9f63dc0c (update SkColorSpace APIs and members). If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
,
Oct 17
,
Oct 17
For what it's worth, I've seen a lot of these style of fuzzer bugs, where arbitrary deserialized data causes Skia to assert, but it's benign. Or, the kind of assert that would indicate a programmer error if it was intentional, but is something a fuzzer could produce. Feel free to WontFix and label as Clusterfuzz-Ignore this if this would not cause something more severe like a security issue.
,
Oct 17
Yeah, we're mostly taking this assert as a reminder to detect and reject these matrices in general... we started our color space work a little overambitious and wrote everything in terms of SkMatrix44 (to support a 3x4 matrix) where really SkMatrix (3x3) will do. Only fuzzers should be producing these >3x3 matrices today... even the ICC parsing code always makes 3x3.
,
Oct 17
The following revision refers to this bug: https://skia.googlesource.com/skia/+/fb1b77b10df9f9a3b053da0cd28392725857aec3 commit fb1b77b10df9f9a3b053da0cd28392725857aec3 Author: Mike Klein <mtklein@google.com> Date: Wed Oct 17 19:36:02 2018 reject non-3x3 gamut matrices A fuzzer has produced one, and hit the existing 4x4 == 3x3 assert. Bug: chromium:895763 Change-Id: Id24b982464166fe5b79ab26c1a3a0e931b76dc4c Reviewed-on: https://skia-review.googlesource.com/c/163166 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@google.com> [modify] https://crrev.com/fb1b77b10df9f9a3b053da0cd28392725857aec3/src/core/SkColorSpace.cpp
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93f9ef9762b0c9158dd8acb0ceb52dbd14a308a3 commit 93f9ef9762b0c9158dd8acb0ceb52dbd14a308a3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Oct 18 07:22:45 2018 Roll src/third_party/skia 0f3d2a60105b..48ee86f818fb (18 commits) https://skia.googlesource.com/skia.git/+log/0f3d2a60105b..48ee86f818fb git log 0f3d2a60105b..48ee86f818fb --date=short --no-merges --format='%ad %ae %s' 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c20ead32ad6d..25843dd65181 (5 commits) 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 54e397425efa..b83d4911baae (1 commits) 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 847fc0b278f8..54e397425efa (1 commits) 2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-18 nigeltao@google.com Have EncodeBench avoid superfluous setup 2018-10-17 nigeltao@google.com Rename EncoderBench.cpp to EncodeBench.cpp 2018-10-17 mtklein@google.com clean up SK_LEGACY_4F_XFERMODES 2018-10-17 fmalita@chromium.org [skottie] Clang-tidy fixes 2018-10-17 halcanary@google.com SkPDF: be smarter about checking to see if a new font is needed. 2018-10-17 jvanverth@google.com Fix NV12 and NV21 images in non-DDL 2018-10-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-17 kjlubick@google.com [canvaskit] Add perf jobs 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms c851ac96663d..f3e50cfac5bc (1 commits) 2018-10-17 mtklein@google.com reject non-3x3 gamut matrices 2018-10-17 caryclark@skia.org fix pathops timeouts 2018-10-17 mtklein@google.com disable legacy shaders in flutter Created with: gclient setdep -r src/third_party/skia@48ee86f818fb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG= chromium:895763 TBR=egdaniel@chromium.org Change-Id: Ifba7c1e3f72463f9a519d9fb401827ae5aaf08c2 Reviewed-on: https://chromium-review.googlesource.com/c/1288019 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600680} [modify] https://crrev.com/93f9ef9762b0c9158dd8acb0ceb52dbd14a308a3/DEPS
,
Oct 18
ClusterFuzz has detected this issue as fixed in range 600679:600680. Detailed report: https://clusterfuzz.com/testcase?key=5142648191713280 Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer Job Type: libfuzzer_chrome_asan_debug Platform Id: linux Crash Type: Abrt Crash Address: 0x05390031a143 Crash State: sk_abort_no_print SkColorSpace::SkColorSpace SkColorSpace::SkColorSpace Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=595362:595363 Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=600679:600680 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5142648191713280 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Oct 18
ClusterFuzz testcase 5142648191713280 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ClusterFuzz
, Oct 16Labels: Test-Predator-Auto-Components