Issue metadata
Sign in to add a comment
|
Regression: [NTP] 'Cancel' and 'Done' buttons are seen misplaced on increasing the font size.
Reported by
sanyam.g...@etouch.net,
Oct 16
|
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3581.0 (Official Build)Revision 694c924ff97377dc28696e1796587cef97b1c10e-refs/branch-heads/3581@{#1}(32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.5, 10.14.1), Linux(14.04 LTS). Pre-Condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags What steps will reproduce the problem? 1. Launch chrome, navigate to 'chrome://settings/fonts' and Change 'Font size' to Huge. 2. Open NTP, click on Gear icon to open 'Customize this page' overlay. 3. Now click on Chrome Backgrounds and observe the buttons on Select a collection overlay. Actual : 'Cancel' and 'Done' buttons are seen misplaced. Expected: 'Cancel' and 'Done' buttons should not be seen misplaced. This is a regression issue, broken in M-71 series, and below is the chromium bisect info: Good Build: 71.0.3552.2(Revision:591211) Bad Build : 71.0.3553.2(Revision:591521) You are probably looking for a change made after 591247 (known good), but no later than 591252 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/c40e051df3d7a68a56d3b972e88c82174af030a1..22a0eea6449d2045c5daedb3f8d1ce24467977c0 Suspect: r591252 ? @sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the screen-cast from the link given below Note: 1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect . revlist: []" error message. 2. Tried on other machines but still getting the same error again. 3. Hence provided suspect through 'Chromium bisect' Thank You!
,
Oct 16
,
Nov 9
,
Nov 14
The NextAction date has arrived: 2018-11-14
,
Nov 29
,
Nov 30
,
Nov 30
,
Dec 4
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0f2d87555e1357e9c43378e45ec0ebebda97232 commit a0f2d87555e1357e9c43378e45ec0ebebda97232 Author: Tina Wang <tinazwang@chromium.org> Date: Tue Dec 04 19:26:43 2018 Fixed the misplaced buttons in the customed background dialog Make the button vertically align to top Bug: 895762 Change-Id: Ida32c453c5880f2ed87199aad03a1d00b90d9204 Reviewed-on: https://chromium-review.googlesource.com/c/1359920 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#613637} [modify] https://crrev.com/a0f2d87555e1357e9c43378e45ec0ebebda97232/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Dec 5
Update: Rechecked the above issue on Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary build #73.0.3631.0 and the issue is fixed. Kindly refer attached screen cast.
,
Dec 5
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ramyan@chromium.org
, Oct 16Labels: -Pri-1 -Target-71 Pri-3
Owner: kristip...@chromium.org