jumbo build fixup after headless network service work |
|||||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/1263566 introduced a jumbo build failure on mainline, which was then fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1277992. But the fix is missing for the chromium 71 release branch. I think we should backport this fix, to avoid causing trouble for downstream projects who rely on jumbo builds. There should be no functional difference with this change (apart from jumbo builds working again).
,
Oct 16
,
Oct 16
Pls apply appropriate OSs label ASAP. Thank you.
,
Oct 16
IIRC this only broke the linux jumbo builder.
,
Oct 16
The special thing with the Linux builder was probably that it builds with non-goma jumbo chunk sizes so it probably broke builds in all operating systems when built with jumbo outside goma.
,
Oct 16
Added other platforms that I know downstream projects build in jumbo mode.
,
Oct 17
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 17
Pls merge your change to M71 branch 3578 ASAP so we can pick it up for next M71 Dev/Beta release. Thank you.
,
Oct 17
Done: https://chromium-review.googlesource.com/c/chromium/src/+/1286663 (Following https://www.chromium.org/developers/how-tos/drover since I have never landed changes on release branches before.)
,
Oct 17
Thank you merge is here: https://chromium.googlesource.com/chromium/src.git/+/1edc83ad4eeceb156b76adfb7b4bb4802c36dbf7
,
Oct 18
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by brat...@opera.com
, Oct 16