Show AudioService information to chrome://media-internals |
|||||||
Issue descriptionShowing AudioService information in chrome://media-internals would simplify debugging greatly.
,
Oct 16
Example screenshot attached.
Example clipboard output:
{
"AudioServiceAudioStreams": "Disabled",
"AudioServiceLaunchOnStartup": "Disabled",
"AudioServiceOutOfProcess": "Disabled",
"AudioServiceSandbox": "Disabled",
"WebRtcApmInAudioService": "Disabled"
}
[
null,
{
"0:0": {
"channel_layout": "STEREO",
"channels": 2,
"component_id": 0,
"component_type": 1,
"device_id": "default",
"device_type": "pcm_low_latency",
"effects": "128",
"frames_per_buffer": 1024,
"owner_id": 0,
"sample_rate": 44100,
"status": "started",
"render_process_id": 16,
"web_contents_title": "YouTube"
}
},
{
"0:0": {
"channel_layout": "STEREO",
"channels": 2,
"component_id": 0,
"component_type": 2,
"device_id": "",
"device_type": "pcm_low_latency",
"effects": "128",
"frames_per_buffer": 1024,
"owner_id": 0,
"sample_rate": 44100,
"status": "started",
"volume": 1
}
}
]
,
Oct 16
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7e5291585f6e626df6cab7bfe5981ad088fe027 commit e7e5291585f6e626df6cab7bfe5981ad088fe027 Author: Henrik Grunell <grunell@chromium.org> Date: Thu Oct 18 07:39:53 2018 Show AudioService information on chrome://media-internals. * Adds capability of showing general audio information on chrome://media-internals in a key-value format. * Shows states of AudioService features (enabled/disabled). * Fixes JS presubmit errors: Use $(id) instead of getElementById(id), and use camelCase for variables. Bug: 895741 Change-Id: I35db3a3ab175586aa7e493ca1acccb1ac7ffa824 Reviewed-on: https://chromium-review.googlesource.com/c/1283020 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600682} [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/media/media_internals.cc [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/media/media_internals.h [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/resources/media/client_renderer.js [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/resources/media/main.js [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/resources/media/manager.js [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/browser/resources/media/media_internals.html [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/test/data/media/webui/integration_test.html [modify] https://crrev.com/e7e5291585f6e626df6cab7bfe5981ad088fe027/content/test/webui_resource_browsertest.cc
,
Oct 18
,
Oct 19
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea commit efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea Author: Henrik Grunell <grunell@chromium.org> Date: Fri Oct 19 08:23:41 2018 Show AudioService information on chrome://media-internals. * Adds capability of showing general audio information on chrome://media-internals in a key-value format. * Shows states of AudioService features (enabled/disabled). * Fixes JS presubmit errors: Use $(id) instead of getElementById(id), and use camelCase for variables. TBR=grunell@chromium.org (cherry picked from commit e7e5291585f6e626df6cab7bfe5981ad088fe027) Bug: 895741 Change-Id: I35db3a3ab175586aa7e493ca1acccb1ac7ffa824 Reviewed-on: https://chromium-review.googlesource.com/c/1283020 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600682} Reviewed-on: https://chromium-review.googlesource.com/c/1290273 Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#153} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/media/media_internals.cc [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/media/media_internals.h [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/media/media_internals_proxy.cc [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/resources/media/client_renderer.js [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/resources/media/main.js [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/resources/media/manager.js [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/browser/resources/media/media_internals.html [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/test/data/media/webui/integration_test.html [modify] https://crrev.com/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea/content/test/webui_resource_browsertest.cc
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea Commit: efa3f704eca01f4fa2f9f01a06a7e9e7604ca0ea Author: grunell@chromium.org Commiter: grunell@chromium.org Date: 2018-10-19 08:23:41 +0000 UTC Show AudioService information on chrome://media-internals. * Adds capability of showing general audio information on chrome://media-internals in a key-value format. * Shows states of AudioService features (enabled/disabled). * Fixes JS presubmit errors: Use $(id) instead of getElementById(id), and use camelCase for variables. TBR=grunell@chromium.org (cherry picked from commit e7e5291585f6e626df6cab7bfe5981ad088fe027) Bug: 895741 Change-Id: I35db3a3ab175586aa7e493ca1acccb1ac7ffa824 Reviewed-on: https://chromium-review.googlesource.com/c/1283020 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#600682} Reviewed-on: https://chromium-review.googlesource.com/c/1290273 Reviewed-by: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#153} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by grunell@chromium.org
, Oct 16