New issue
Advanced search Search tips

Issue 895739 link

Starred by 1 user
Status: WontFix
Owner:
ftirelo@chromium.org
Closed: Oct 22
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Add' button disappears on disabling the toggle button on Settings page.

Reported by dchau...@etouch.net, Oct 16 
Chrome Version: 72.0.3581.0 (Official Build) Revision	694c924ff97377dc28696e1796587cef97b1c10e-refs/branch-heads/3581@{#1} (32/64-bit)
OS: Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.13.1, 10.13.6, 10.14)

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://settings/payments
2. Now disable the toggle button and observe the 'Add' button.

Actual: 'Add' button disappears on disabling the toggle button.
Expected: 'Add' button should get disabled on disabling the toggle button.

This is a regression issue, broken in M-71 series, will soon update bisect info.

NOTE: This issue is also reproducible on chrome://settings/autofill page.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
471 KB View Download
Expected behavior.mp4
437 KB View Download

Comment 1 by dchau...@etouch.net, Oct 16

Labels: hasbisect
Owner: ftirelo@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range:

Good build: 71.0.3569.0 (Revision: 596016)
Bad build: 71.0.3570.0 (Revision: 596428)

You are probably looking for a change made after 596270 (known good), but no later than 596280 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/ef5063ca49f180e80fd154b761fc72deb41da4a9..fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344

Suspecting: https://chromium.googlesource.com/chromium/src/+/1cef206244b29575391e471c2a11a052d993bcbb

@ftirelo: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.

Thank you.

Comment 2 by rbasuvula@chromium.org, Oct 16 

@fabio: Its look like intended change.Could you please confirm once.
Thank You!

Comment 3 by ftirelo@chromium.org, Oct 22

Status: WontFix (was: Assigned)
Sorry for the delay.

This is the intended behavior. There is no reason to add new cards if they can't be used. The same will happen on chrome://settings/autofill.
►

Sign in to add a comment