New issue
Advanced search Search tips

Issue 895733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression : In print preview, 'Scale' value is not seen after changing the font size to 'Very small'.

Reported by avsha...@etouch.net, Oct 16

Issue description

Chrome Version : 72.0.3581.0 (Official Build) 694c924ff97377dc28696e1796587cef97b1c10e-refs/branch-heads/3581@{#1} 32/64 bit
OS : Mac(10.13.1, 10.14.1, 10.13.6), Linux(14.04 LTS), Windows(7,8,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings page and set 'Font size' to 'Very small'.
2. Now press, 'Cmd + P' to open print preview and choose any available printer from 'Destination' list.
3. Expand 'More settings' section and observe value in 'Scale' text box.

Actual Result : 'Scale' value is not seen after changing the font size to 'Very small'. (Instead of value, it just shows text continuation)

Expected Result : 'Scale' value should be completely visible to the user even when font size is set to 'Very small'.

This is a regression issue broken in M-71 and below is the bisect information:
Good Build : 71.0.3557.0 (Revision : 592638)
Bad Build : 71.0.3558.0 (Revision : 593042)

Chromium bisect URL:
https://chromium.googlesource.com/chromium/src/+log/bf4136b10c3fe26c6a2edea9b181bf1d060b894b..0663980bf2c4f570626981f59d7cfbadd855ba85

Suspecting : r592985

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:

1. Unable to provide bisect using per-revision script as it shows "We don't have enough builds error message"
2. Tried on other machines but still getting the same error again.
3. Hence provided suspect through 'Chromium bisect'
4. Able to repro issue in Dev #71.0.3573.0 and the same is working fine in Stable build #70.0.3538.67 & Beta #70.0.3538.54

Thank you..!
 
Actual_Result.mov
6.5 MB View Download
Expected_Result.mov
5.9 MB View Download
Print_Preview.png
19.7 KB View Download
Labels: -Pri-1 Pri-3
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29d287688e29161dc12a1fd9fd38948aa0a461c7

commit 29d287688e29161dc12a1fd9fd38948aa0a461c7
Author: rbpotter <rbpotter@chromium.org>
Date: Thu Oct 18 02:02:26 2018

Print Preview Refresh: fix very small font issue

Bug:  895733 
Change-Id: Iee9b0deb1016d28c8d6b4c870cdd452c52feda71
Reviewed-on: https://chromium-review.googlesource.com/c/1285116
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600635}
[modify] https://crrev.com/29d287688e29161dc12a1fd9fd38948aa0a461c7/chrome/browser/resources/print_preview/new/number_settings_section.html

Status: Fixed (was: Assigned)
Works on Canary 72.0.3588.0 on Windows 10.

Sign in to add a comment