New issue
Advanced search Search tips

Issue 895732 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

zygote process should not be created with '--no-sandbox --no-zygote' flags

Reported by wanchang...@lge.com, Oct 16

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3582.0 Safari/537.36

Steps to reproduce the problem:
1. Launch chrome with flags '--no-sandbox --no-zygote'
2. Check zygote process existence by ps -ax command

What is the expected behavior?
Process with --type=zygote should not exist.

What went wrong?
When checking running process, process with --type=zygote exists

Did this work before? Yes 

Chrome version: 72.0.3582.0  Channel: n/a
OS Version: 
Flash Version:
 
I think https://chromium-review.googlesource.com/c/chromium/src/+/509529 this commit broke behavior.
I'd like to upload the fix for this regression.
Cc: skyos...@chromium.org
Components: Internals>Sandbox
Labels: Needs-Bisect Needs-Triage-M72
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Needs-Feedback
wanchang.ryu@ Thanks for the issue...

Tried to reproduce the issue on reported chrome version 72.0.3582.0 using Ubuntu 14.04. Attaching screen-cast for reference.
Steps: 
---------
1. Launched reported chrome with flags '--no-sandbox --no-zygote'
2. entered command in terminal > ps -ax 
As we are observed that chrome process not exist.

@Reporter: Could you please check the attached screen cast and please let us know if anything missed from our end.

Thanks..!
895732.ogv
3.9 MB View Download
Hi phanindra.mandapaka,
You need to launch another shell and exec 'ps -ax | grep chrome'  to see the zygote process.
$ ps -ax | grep chrome
24107 pts/19   S+     0:01 xxxxx/chromium/src/out/Default/chrome --type=zygote --no-sandbox

I expect that chrome shouldn't create the zygote process with flags of '--no-sandbox --no-zygote'

Thanks.

Project Member

Comment 7 by sheriffbot@chromium.org, Oct 18

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
wanchang.ryu@ Thanks for the feedback...
 
As per comment #6, Tried to reproduce the issue on 72.0.3582.0 using Ubuntu 14.04. Attaching screenshot for reference.
Steps:
1. Launched reported chrome with flags '--no-sandbox --no-zygote'
2. Opened another terminal and entered command > ps -ax | grep chrome


@Reporter: As we are seen same behaviour from M-60 to reported chrome 72.0.3582.0 as per attached screenshot. Could you please have a look at the screenshots and let us know if the expected behaviour or Is the issue seen in both the versions. Your confirmation helps us to triage the issue further in a better way.  

Thanks...
895732.png
238 KB View Download
895732-1.png
240 KB View Download
895732-2.png
202 KB View Download
I can say the issue exists in the screen shot.
Could you check chrome 59 ? I think this version doesn't have the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 18

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Bisect Target-72 M-72 FoundIn-71 FoundIn-70 FoundIn-72
Status: Untriaged (was: Unconfirmed)
wanchang.ryu@ Thanks for the Confirmation...

As per comment #9, Able to reproduce the issue on reported chrome version 72.0.3582.0 also on latest chrome 72.0.3586.0 using Ubuntu 14.04.  
 
Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged. Issue seen on Ubuntu and removing Needs-Bisect label to it.

Thanks..! 
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc1b6354e001daa79df81cd5d8b025cc846da26b

commit fc1b6354e001daa79df81cd5d8b025cc846da26b
Author: Wanchang, Ryu <wanchang.ryu@lge.com>
Date: Thu Oct 25 02:56:08 2018

Skip creating zygote with --no-zygote flag

This CL fixed the side effect of
https://chromium-review.googlesource.com/c/chromium/src/+/509529
By above commit, browser creates zygote process even with --no-sandbox
--no-zygote flags. Zygote process should not be created with
--no-sandbox --no-zygote flags.

Bug:  895732 
Change-Id: I2e2bebbab69b4ac5047cc33aa346942b83a67183
Reviewed-on: https://chromium-review.googlesource.com/c/1282687
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602590}
[modify] https://crrev.com/fc1b6354e001daa79df81cd5d8b025cc846da26b/content/app/content_main_runner_impl.cc
[modify] https://crrev.com/fc1b6354e001daa79df81cd5d8b025cc846da26b/content/test/BUILD.gn
[modify] https://crrev.com/fc1b6354e001daa79df81cd5d8b025cc846da26b/content/zygote/zygote_browsertest.cc
[modify] https://crrev.com/fc1b6354e001daa79df81cd5d8b025cc846da26b/services/service_manager/zygote/host/zygote_host_impl_linux.h

I think this issue would be fixed by https://chromium-review.googlesource.com/c/1282687
Status: Fixed (was: Untriaged)
Thanks for the fix!

Sign in to add a comment