Flaky test: external/wpt/css/css-layout-api/edges/scrollbar.https.html Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4093fcaabc89c410 Test output log: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I3b53be9b44989d919cb657d4eabc6d3a1a79181b Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKqAWNocm9taXVtLm1hYy9NYWMxMC4xMCBUZXN0cy8zNTQxNC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMC41L1pYaDBaWEp1WVd3dmQzQjBMMk56Y3k5amMzTXRiR0Y1YjNWMExXRndhUzlsWkdkbGN5OXpZM0p2Ykd4aVlYSXVhSFIwY0hNdWFIUnRiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/css/css-layout-api/edges/scrollbar.https.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy4QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKqAWNocm9taXVtLm1hYy9NYWMxMC4xMCBUZXN0cy8zNTQxNC93ZWJraXRfbGF5b3V0X3Rlc3RzIG9uIChub25lKSBHUFUgb24gTWFjIG9uIE1hYy0xMC4xMC41L1pYaDBaWEp1WVd3dmQzQjBMMk56Y3k5amMzTXRiR0Y1YjNWMExXRndhUzlsWkdkbGN5OXpZM0p2Ykd4aVlYSXVhSFIwY0hNdWFIUnRiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7ff5c099bb69d7eef5467268877cb11cdd1d838 commit a7ff5c099bb69d7eef5467268877cb11cdd1d838 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Oct 16 06:17:13 2018 Revert "[css-layout-api] Add LayoutEdges." This reverts commit 980bc9b6532b0980721c123fa29fa561bc503f91. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414 Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5 Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html Original change's description: > [css-layout-api] Add LayoutEdges. > > This allows web developers to access pre-computed sizes for the border, > scrollbar, and padding "edges". > > This adds two types of tests: > 1) Uses the standard "green box" approach of testing the script values > match what is expected. > 2) Positions four children at each corner (using edges) are positioned > the same as using an abs-pos technique. > > Bug: 726125 > Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b > Reviewed-on: https://chromium-review.googlesource.com/c/1252776 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599680} Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726125, 895731 Reviewed-on: https://chromium-review.googlesource.com/c/1282724 Cr-Commit-Position: refs/heads/master@{#599889} [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/all-ref.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/all.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-htb-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-htb.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-vlr-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-vlr.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-vrl-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/border-vrl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-htb-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-htb.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-vlr-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-vlr.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-vrl-rtl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/padding-vrl.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/scrollbar-ref.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/edges/scrollbar.https.html [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/WebKit/LayoutTests/external/wpt/css/css-layout-api/support/edges.js [modify] https://crrev.com/a7ff5c099bb69d7eef5467268877cb11cdd1d838/third_party/blink/renderer/core/core_idl_files.gni [modify] https://crrev.com/a7ff5c099bb69d7eef5467268877cb11cdd1d838/third_party/blink/renderer/core/layout/BUILD.gn [modify] https://crrev.com/a7ff5c099bb69d7eef5467268877cb11cdd1d838/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/blink/renderer/core/layout/custom/custom_layout_edges.cc [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/blink/renderer/core/layout/custom/custom_layout_edges.h [delete] https://crrev.com/d6daeef22be35dd14764da5d6078c50315124922/third_party/blink/renderer/core/layout/custom/layout_edges.idl [modify] https://crrev.com/a7ff5c099bb69d7eef5467268877cb11cdd1d838/third_party/blink/renderer/core/layout/layout_box_model_object.h
Issue 895734 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Oct 16