Issue metadata
Sign in to add a comment
|
Enforce URLBlacklist for chrome://settings/password not working
Reported by
ay...@coditas.com,
Oct 16
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36 Steps to reproduce the problem: 1. Enforce URLBlacklist policy with chrome://settings/password 2. try to open chrome://settings/password will show blocked screen 3. try to open chrome://settings and now click on password will open password settings What is the expected behavior? Navigation to chrome://settings/password from any page should be blocked. What went wrong? The URLBlacklist policy is not working properly. Did this work before? N/A Does this work in other browsers? N/A Chrome version: 69.0.3497.100 Channel: stable OS Version: Flash Version:
,
Oct 16
[jam]: One of the issues I mentioned. [atwilson]: Possible duplicate of issue 876600 ?
,
Oct 17
this is not a duplicate of issue https://bugs.chromium.org/p/chromium/issues/detail?id=876600 as that issue talks about blacklisting of extensions and here we are talking about urlBlacklisting.
,
Oct 17
Basically, clicking on things on that page is not actually doing a navigation (no URLs are being fetched). Instead, javascript is just modifying the DOM then pushing URLs on the history stack. URLBlacklist cannot usefully do anything in that case because we can't stop Javascript from modifying the DOM.
,
Oct 17
But the URLBlacklist policy says so. If you are pushing the url on stack and updating it in navigation bar than we should also check if this url was blacklisted.
,
Oct 17
Getting pedantic for a minute: The URLBlacklist policy says "This policy prevents the user from loading web pages from blacklisted URLs" - in this case, we are not loading web pages. In fact, hitting refresh in the browser should trigger URLBlacklisting because in that case we are actually loading a web page. URLBlacklist policy documentation does *not* state that it blocks modifying the URL history via Javascript. Additionally, policy documentation states: "Note that it is not recommended to block internal 'chrome://*' URLs since this may lead to unexpected errors." Again, the appropriate way to handle this use case would be via a policy to make some parts of the settings page inaccessible. The fact that clicking on "Passwords" in settings currently navigates to chrome://settings/passwords is not a binding public API - it is an implementation detail and is subject to change. This really should be driven through a dedicated policy. In any case, I think your feature request to have URLBlacklist also restrict which URLs can be pushed on the history stack is reasonable - please bring it up on crbug.com/731104 so it can be prioritized along with the other policy-restricted-settings request. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Oct 16