New issue
Advanced search Search tips

Issue 895695 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::AudioOutputDeviceClient::From

Project Member Reported by ClusterFuzz, Oct 16

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5685556498137088

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000248
Crash State:
  blink::AudioOutputDeviceClient::From
  blink::SetSinkIdResolver::TimerFired
  blink::TimerBase::RunInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=599727:599731

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5685556498137088

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 16

Components: Blink>WebRTC Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 16

Labels: Test-Predator-Auto-Owner
Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/58181c2588984a85a2aad35e4a209616cf2fa641 (Implement C++ style dynamic casting operators for Blink).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Oct 18

Labels: OS-Linux
Cc: guidou@chromium.org tommi@chromium.org
Components: -Platform
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1288674, though I'm hoping someone from webrtc can help with reducing the test case, since I'm not very familiar with <audio>
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a87e76e3233e5379667eab3c8e26bbf5390165df

commit a87e76e3233e5379667eab3c8e26bbf5390165df
Author: Daniel Cheng <dcheng@chromium.org>
Date: Tue Oct 23 15:43:40 2018

Null check context in HTMLMediaElementAudioOutputDevice

This was introduced by r596416, which incorrectly assumed the
pre-existing DCHECK(context) was true. It is not.

Bug:  895695 
Change-Id: I260c5d613d40e68da6ac1926176e060eb8c49b66
Reviewed-on: https://chromium-review.googlesource.com/c/1288674
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601965}
[modify] https://crrev.com/a87e76e3233e5379667eab3c8e26bbf5390165df/third_party/blink/renderer/modules/audio_output_devices/html_media_element_audio_output_device.cc

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Oct 24

ClusterFuzz has detected this issue as fixed in range 601924:601925.

Detailed report: https://clusterfuzz.com/testcase?key=5685556498137088

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000248
Crash State:
  blink::AudioOutputDeviceClient::From
  blink::SetSinkIdResolver::TimerFired
  blink::TimerBase::RunInternal
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=599708:599727
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=601924:601925

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5685556498137088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 24

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5685556498137088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment