New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895694 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

CWVCreditCardVerifier needs Risk Data to perform verification

Project Member Reported by jzw@chromium.org, Oct 16

Issue description

CWVCreditCardVerifier needs to contact payments API underneath and requires additional risk data that can only be provided by 1st party client apps.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c614137c674cefee464d98674cb35039b6a2c10d

commit c614137c674cefee464d98674cb35039b6a2c10d
Author: John Z Wu <jzw@chromium.org>
Date: Tue Oct 16 22:47:39 2018

Add API to obtain risk data from client app in CWVCreditCardVerifier.

Risk data is needed during credit card verification in order to
communicate with payments API, and it can only be obtained by a
1st party app.

Bug:  895694 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I79ee7cddf9618ee32e4050f0b3b4b61447e7ea1f
Reviewed-on: https://chromium-review.googlesource.com/c/1282388
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600159}
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/BUILD.gn
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/cwv_autofill_client_ios_bridge.h
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/cwv_autofill_controller.mm
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/cwv_credit_card_verifier.mm
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/cwv_credit_card_verifier_internal.h
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
[modify] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/public/cwv_credit_card_verifier.h
[add] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/public/cwv_credit_card_verifier_data_source.h
[add] https://crrev.com/c614137c674cefee464d98674cb35039b6a2c10d/ios/web_view/public/cwv_credit_card_verifier_delegate.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8960154b5498a7ab27cddc9b56ba8909b2050cb9

commit 8960154b5498a7ab27cddc9b56ba8909b2050cb9
Author: John Z Wu <jzw@chromium.org>
Date: Thu Oct 25 04:33:13 2018

Fix timing for getting risk data in CWVCreditCardVerifier.

CWVCreditCardVerifier should ask for risk data when user begins
verification because that's when |_dataSource| will be available.

Bug:  895694 
Change-Id: Ic74b638eff9ed473767132722e48da36616c76af
Reviewed-on: https://chromium-review.googlesource.com/c/1298113
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602611}
[modify] https://crrev.com/8960154b5498a7ab27cddc9b56ba8909b2050cb9/ios/web_view/internal/autofill/cwv_credit_card_verifier.mm
[modify] https://crrev.com/8960154b5498a7ab27cddc9b56ba8909b2050cb9/ios/web_view/internal/autofill/cwv_credit_card_verifier_unittest.mm
[modify] https://crrev.com/8960154b5498a7ab27cddc9b56ba8909b2050cb9/ios/web_view/public/cwv_credit_card_verifier.h

Status: Fixed (was: Available)

Sign in to add a comment