New issue
Advanced search Search tips

Issue 895691 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug
M71



Sign in to add a comment

Ill in v8::internal::compiler::RepresentationChanger::TypeError

Project Member Reported by ClusterFuzz, Oct 16

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4779650419785728

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: Ill
Crash Address: 0x555d9b8e534e
Crash State:
  v8::internal::compiler::RepresentationChanger::TypeError
  v8::internal::compiler::RepresentationChanger::GetFloat32RepresentationFor
  v8::internal::compiler::RepresentationSelector::ConvertInput
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=56433:56434

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4779650419785728

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 16

Components: Blink>JavaScript>Compiler
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 16

Labels: Test-Predator-Auto-Owner
Owner: neis@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/6c86b81af82f537821ec3306a000e02af92127c5 ([turbofan] Don't constant-fold typed-array with on-heap buffer.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Fixed (was: Assigned)
Fix landed as https://chromium-review.googlesource.com/c/v8/v8/+/1282990

(Accidentally used the wrong bug reference prefix).
Project Member

Comment 4 by ClusterFuzz, Oct 16

ClusterFuzz has detected this issue as fixed in range 56690:56691.

Detailed report: https://clusterfuzz.com/testcase?key=4779650419785728

Fuzzer: ochang_js_fuzzer
Job Type: linux_ubsan_vptr_d8
Platform Id: linux

Crash Type: Ill
Crash Address: 0x555d9b8e534e
Crash State:
  v8::internal::compiler::RepresentationChanger::TypeError
  v8::internal::compiler::RepresentationChanger::GetFloat32RepresentationFor
  v8::internal::compiler::RepresentationSelector::ConvertInput
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=56433:56434
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_d8&range=56690:56691

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4779650419785728

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Oct 16

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4779650419785728 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Issue 912442 has been merged into this issue.
Cc: hablich@chromium.org
Labels: Merge-Approved-71
Labels: -Merge-Approved-71 Merge-Request-71
 bmeurer@, are you requesting a merge to M71? Also is this merge needed to M72 as well?

Changing label to "Merge-request-71". hablich@ for merge review.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 7

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Android OS-Chrome OS-Mac OS-Windows
This is V8 merge so applying all applicable OSs.
Issue 912635 has been merged into this issue.
Labels: Target-71 M71 ReleaseBlock-Stable
Labels: -Merge-Review-71 Merge-Approved-71
Pls merge before 1:00 PM PT, Monday (12/10) so we can pick it up for next M71 stable release. Thank you.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 10

Labels: merge-merged-7.1
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5503d5d3ee695c039d913d218b839ad255265663

commit 5503d5d3ee695c039d913d218b839ad255265663
Author: Jaroslav Sevcik <jarin@chromium.org>
Date: Mon Dec 10 09:18:19 2018

Merged: [turbofan] Allow converting word64 to float32 if value is safe integer.

Revision: a8cb521a58cd69002a31e704bc2c9bb133181f2e

BUG= chromium:895691 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bmeurer@chromium.org

Change-Id: Ice8d26a10acb7e0eafc4e0e6ae79e89c1a0c55cc
Reviewed-on: https://chromium-review.googlesource.com/c/1369944
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.1@{#63}
Cr-Branched-From: f70aaa8ab2e8815505a6145c745e50d8328cd28c-refs/heads/7.1.302@{#1}
Cr-Branched-From: 1dbcc78efa17a9047f7e923958087ef9eec43066-refs/heads/master@{#56462}
[modify] https://crrev.com/5503d5d3ee695c039d913d218b839ad255265663/src/compiler/representation-change.cc
[add] https://crrev.com/5503d5d3ee695c039d913d218b839ad255265663/test/mjsunit/regress/regress-895691.js

Is this change need a merge to M72?
Labels: -Merge-Approved-71
Already merged to M71 at #15.
This is already in M72.
Thank you hablich@.

Sign in to add a comment