Bundle findinpage injection |
||||||
Issue descriptionCurrently, FindinPage is injected into the mainframe when the FindInPageController is initialized. It would be ideal to move the injection logic into frame bundling to help solve the issue of searching in cross-domain iframes. That way, each frame has the injection and //ios/web code logic can just execute functions without having to check or assuming that FindInPageController has injected it.
,
Oct 25
,
Oct 26
,
Nov 16
**Mass UI Triage ** Based on #3, adding appropriate labels. thegreenfrog@,Please take a look and update the thread accordingly.
,
Nov 16
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7226af3878f4c9c10d722b8af0a1d0509a3b8b07 commit 7226af3878f4c9c10d722b8af0a1d0509a3b8b07 Author: Chris Lu <thegreenfrog@chromium.org> Date: Sat Dec 08 02:41:57 2018 [ios] New Find in Page JS Add copy of //ios/chrome/browser/find_in_page/resources/find_in_page.js into //ios/web and bundle it in the JavaScript injected into all frames. Bug: 895641 Change-Id: Ia6873413810c9cc0b69ee4940daf53174d4e5a45 Reviewed-on: https://chromium-review.googlesource.com/c/1366755 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#614928} [modify] https://crrev.com/7226af3878f4c9c10d722b8af0a1d0509a3b8b07/ios/chrome/browser/find_in_page/resources/find_in_page.js [modify] https://crrev.com/7226af3878f4c9c10d722b8af0a1d0509a3b8b07/ios/web/BUILD.gn [modify] https://crrev.com/7226af3878f4c9c10d722b8af0a1d0509a3b8b07/ios/web/web_state/js/resources/all_frames_web_bundle.js [add] https://crrev.com/7226af3878f4c9c10d722b8af0a1d0509a3b8b07/ios/web/web_state/js/resources/find_in_page.js
,
Dec 11
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by robliao@chromium.org
, Oct 25