Media Controls: Click anywhere to play/pause |
||
Issue descriptionOn desktop, we want users to be able to click anywhere on the video to play or pause. Note that this needs to work cleanly with double-click to go fullscreen on desktop: 1) Paused video, single-click: start playing after double-tap timer has completed. Don't toggle fullscreen 2) Paused video, double-click: Do nothing on first click. Toggle fullscreen on second click. 3) Playing video, single-click: pause immediately. Don't toggle fullscreen 4) Playing video, double-click: pause immediately on first click. Toggle fullscreen and resume playback on second click
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4 commit 5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Oct 30 16:54:41 2018 Media Controls: Click anywhere to play/pause This CL adds event handling to allow users to click anywhere on a video to toggle play or pause. Pausing happens immediately, while playing happens after waiting for the double-tap delay. If we pause and then the double-tap happens, we resume playback. Bug: 895636 Change-Id: Idf161767900b3dc03501f8034f0c589c4e5d5800 Reviewed-on: https://chromium-review.googlesource.com/c/1286870 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603930} [modify] https://crrev.com/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4/third_party/WebKit/LayoutTests/media/controls/click-anywhere-to-play-pause.html [modify] https://crrev.com/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html [modify] https://crrev.com/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/5e690a2d7ec6ac9e758a894aec1eb3e877c6c7f4/third_party/blink/renderer/modules/media_controls/media_controls_impl.h
,
Oct 30
|
||
►
Sign in to add a comment |
||
Comment 1 by steimel@chromium.org
, Oct 16Status: Started (was: Available)