New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895633 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Navi] gzip onboarding_welcome/ resources.

Project Member Reported by scottchen@chromium.org, Oct 15

Issue description

Cc: -dpa...@chromium.org
Owner: dpa...@chromium.org
Status: Assigned (was: Available)
Preparatory CL at https://chromium-review.googlesource.com/c/chromium/src/+/1285210.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada

commit b1f8e9a1fc0d9377d4e434b8782684088bcd5ada
Author: dpapad <dpapad@chromium.org>
Date: Thu Oct 18 21:36:08 2018

Onboarding WebUI: Add dedicated grd file to hold all files.

This is in preparation of gzipping files for this WebUI.
Bug: 895633

Change-Id: I43cbb74a11a5ab6317cf2a4cf42d77592a06ae46
Reviewed-on: https://chromium-review.googlesource.com/c/1285210
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600919}
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/BUILD.gn
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/browser_resources.grd
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/resources/BUILD.gn
[add] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/ui/webui/welcome/nux/email_handler.cc
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.cc
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/ui/webui/welcome/nux/set_as_default_handler.h
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/browser/ui/webui/welcome/welcome_ui.cc
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/chrome/chrome_paks.gni
[modify] https://crrev.com/b1f8e9a1fc0d9377d4e434b8782684088bcd5ada/tools/gritsettings/resource_ids

Status update:
CL at https://chromium-review.googlesource.com/c/chromium/src/+/1313075 is moving all image resources to the onboarding_welcome.grd file. After that lands, it should be easier to enable gzip for all non-image resources in onboarding_welcome.grd and welcome_ui.cc accordingly.

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53a5c5e7ac5defffa948b93766aeab2bf100a0be

commit 53a5c5e7ac5defffa948b93766aeab2bf100a0be
Author: dpapad <dpapad@chromium.org>
Date: Fri Nov 02 00:30:56 2018

Onboarding WebUI: Move all images to the dedicated .grd file.

Bug: 895633
Change-Id: I6ce9829dedf5af302cce660d9d8bc09f7d63af39
Reviewed-on: https://chromium-review.googlesource.com/c/1313075
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604769}
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/browser_resources.grd
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.html
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.html
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.html
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/resources/welcome/onboarding_welcome/onboarding_welcome_resources.grd
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/ui/webui/welcome/nux/email_handler.cc
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/ui/webui/welcome/nux/google_apps_handler.h
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/chrome/browser/ui/webui/welcome/welcome_ui.cc
[modify] https://crrev.com/53a5c5e7ac5defffa948b93766aeab2bf100a0be/tools/gritsettings/resource_ids

Sign in to add a comment