New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895632 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Separate DataPoint from MasterFlakeAnalysis

Project Member Reported by lijeffrey@chromium.org, Oct 15

Issue description

DataPoint is a class that lives within the master_flake_analysis.py

It should instead live outside in its own file in preparation to save data points to ndb
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2dbddce398eb6c3f8beeaec24be92a98403a5a4d

commit 2dbddce398eb6c3f8beeaec24be92a98403a5a4d
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Oct 19 23:07:02 2018

[Findit] Flake Analyzer - Separate DataPoint from MasterFlakeAnalysis

Moving DataPoint into its own file - no functional change. Eventually,
DataPoint objects will be saved individually to ndb for lookup by other
analyses.

Bug:  895632 
Change-Id: I383d462f66ac91b402f827b727641fc5c3a825f4
Reviewed-on: https://chromium-review.googlesource.com/c/1281993
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18500}
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/waterfall/flake/test/initialize_flake_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/culprit_util_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/heuristic_analysis_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/test/event_reporting_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/lookback_algorithm_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/update_monorail_bug_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/save_flakiness_verification_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[add] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/model/flake/analysis/data_point.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/flake_report_util_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/confidence_score_util_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/next_commit_position_utils_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/model/flake/analysis/master_flake_analysis.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/data_point_util.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/analyze_recent_flakiness_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/model/flake/analysis/test/master_flake_analysis_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/flake_try_job.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/flake_try_job_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/data_point_util_test.py
[add] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/model/flake/analysis/test/data_point_test.py
[modify] https://crrev.com/2dbddce398eb6c3f8beeaec24be92a98403a5a4d/appengine/findit/services/flake_failure/test/confidence_test.py

Status: Fixed (was: Started)

Sign in to add a comment