Shelf icon size warning spamming chrome log |
||||||
Issue descriptionShelfButton::SetImage could be called pretty often. Once user has an app with smallish icon, LOG(WARNING) in [1] would spam chrome's log. Can we reduce the noise from this log? e.g. add a static bool and log it only once ? [1] https://cs.chromium.org/chromium/src/ash/shelf/shelf_button.cc?rcl=63fd641525b509637f4599c5bf6e7868384c5cdc&l=359
,
Dec 12
,
Dec 12
,
Dec 12
,
Jan 7
... or maybe I should consider whoever owns these icons as sufficiently warned, and people will file a bug against that if they find icons looking blurry in the actual UI. Maybe spamming the developer's log isn't the most efficient way to get the message across.
,
Jan 9
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8a5a253d051d5778ae12c406236c67f87347ec5 commit a8a5a253d051d5778ae12c406236c67f87347ec5 Author: Manu Cornet <manucornet@chromium.org> Date: Thu Jan 10 05:43:43 2019 CrOS: Remove log spam from small icon (See the bug report for more context) Bug: 895622 Change-Id: Id7153cfb36ce7fdf23127127679c95074ed3b71c Reviewed-on: https://chromium-review.googlesource.com/c/1401983 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#621476} [modify] https://crrev.com/a8a5a253d051d5778ae12c406236c67f87347ec5/ash/shelf/shelf_button.cc
,
Jan 10
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by manucornet@chromium.org
, Dec 8