New issue
Advanced search Search tips

Issue 895619 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 19
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove PointerEvent

Project Member Reported by sky@chromium.org, Oct 15

Issue description

At this point it's not largely not used, and should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08436a53b889d2a380f8a16e05e74507d1cf8acc

commit 08436a53b889d2a380f8a16e05e74507d1cf8acc
Author: Scott Violet <sky@chromium.org>
Date: Mon Oct 15 23:08:58 2018

chromeos: remove unnecessary event conversion

Now that there is serialization code for mouse/touch, this code should
no longer be needed.

BUG= 895619 
TEST=covered by tests

Change-Id: Ia439067d35dd239e914b8bace1164f97bba5c26e
Reviewed-on: https://chromium-review.googlesource.com/c/1282032
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599770}
[modify] https://crrev.com/08436a53b889d2a380f8a16e05e74507d1cf8acc/ash/public/cpp/remote_shelf_item_delegate.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b4f0c18f2f029aec943eb92216f97ff4d20676

commit 88b4f0c18f2f029aec943eb92216f97ff4d20676
Author: Scott Violet <sky@chromium.org>
Date: Tue Oct 16 16:01:26 2018

chromeos: remove usage of PointerEvent in AdaptiveScreenBrightnessManager

PointerEvents are never generated by the system, so this code is never reached.
PointerEvent is going to be removed shortly.

BUG= 895619 
TEST=covered by tests

Change-Id: Ie8f65ed28d1f00a2f27093acab242a5d679944a1
Reviewed-on: https://chromium-review.googlesource.com/c/1282206
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600005}
[modify] https://crrev.com/88b4f0c18f2f029aec943eb92216f97ff4d20676/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/88b4f0c18f2f029aec943eb92216f97ff4d20676/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager_unittest.cc
[modify] https://crrev.com/88b4f0c18f2f029aec943eb92216f97ff4d20676/ui/events/event.cc
[modify] https://crrev.com/88b4f0c18f2f029aec943eb92216f97ff4d20676/ui/events/event.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6

commit 7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6
Author: Scott Violet <sky@chromium.org>
Date: Fri Oct 19 16:53:51 2018

removes ui::PointerEvent

It's no longer used.

BUG= 895619 
TEST=none

Change-Id: I9f5c713988f8c5838bc99769cd418778c9e3aa5c
Reviewed-on: https://chromium-review.googlesource.com/c/1285121
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601189}
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ash/public/cpp/immersive/immersive_fullscreen_controller.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ash/wm/workspace/backdrop_controller.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/services/ws/event_test_utils.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/services/ws/server_window.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/blink/blink_event_util.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/event.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/event.h
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/event_constants.h
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/event_unittest.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/event_utils.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/mojo/event.mojom
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/mojo/event_constants.mojom
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/mojo/event_struct_traits.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/mojo/event_struct_traits.h
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/events/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/7c8cd223fb34c6d2683eb5cd79cb6d1e367f45d6/ui/views/event_utils.cc

Status: Fixed (was: Started)

Sign in to add a comment