[LayoutNG] fast/inline/outline-offset.html margins+inline+replaced cause render difference |
|||
Issue descriptionThis is not an outline bug. The way margins are handled causes the bug. Simplified test case: <span style="outline:black solid 1px"><textarea style="margin-left:100px;width:40px;height:100px"></textarea></span>
,
Oct 16
,
Oct 16
This is not the same bug at #889721. The margins are the problem here. Margins + continuations? It can be demonstrated without any outlines: <span style="background-color: yellow;"><textarea style="margin-left:100px;width:40px;height:100px;background-color:green"></textarea></span>
,
Oct 16
Yeah, it fails because the continuation is an empty line, and we handle empty line box incorrectly. If you make them non-empty, it works as expected.
,
Oct 16
Ah, wait, textarea is not needed, just inline-block can reproduce, so not about continuations.
,
Oct 16
👍🏾
,
Oct 16
Legacy and WebKit look incorrect too, the height of the line box should include the height of atomic inline. Gecko and Edge does this correctly.
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0ebd8f1443a2876284f0253bc9f00baaaa273fc commit c0ebd8f1443a2876284f0253bc9f00baaaa273fc Author: Koji Ishii <kojii@chromium.org> Date: Tue Oct 30 13:54:37 2018 [LayoutNG] Fix inline boxes when the first child has left margin This patch fixes the left edge of inline boxes when its first child is an atomic inline that has left margin. Inline boxes without children are handled in the same way and that this patch fixes them too. NGInlineLayoutAlgorithm uses left margin when it computes the border box of children. However, when creating boxes that wrap such child, margin edge is needed. Bug: 895611 , 636993 Change-Id: I4ffb67b5903a1f0ef90c1da741f1a3a33aa9c1af Reviewed-on: https://chromium-review.googlesource.com/c/1306968 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603883} [modify] https://crrev.com/c0ebd8f1443a2876284f0253bc9f00baaaa273fc/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/c0ebd8f1443a2876284f0253bc9f00baaaa273fc/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc [modify] https://crrev.com/c0ebd8f1443a2876284f0253bc9f00baaaa273fc/third_party/blink/renderer/core/layout/ng/inline/ng_line_box_fragment_builder.h
,
Oct 30
,
Oct 30
\o/ |
|||
►
Sign in to add a comment |
|||
Comment 1 by kojii@chromium.org
, Oct 16