New issue
Advanced search Search tips

Issue 895601 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

TypeError: cannot concatenate 'str' and 'instance' objects

Project Member Reported by cbiesin...@chromium.org, Oct 15

Issue description

Owner: nedngu...@google.com
Status: Started (was: Untriaged)
That's due to my CL recently.
Components: -Infra>Platform>Buildbot>TryServer
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09dcd00f7f832753594286999666ddb14c796f7a

commit 09dcd00f7f832753594286999666ddb14c796f7a
Author: Ned Nguyen <nednguyen@google.com>
Date: Tue Oct 16 06:01:50 2018

Reland "[testing/scripts] Add base adapter class that enables more code reuse for all isolated script test"

This is a reland of 18e40bdceea9a7a147d99e35cf138c7872d9d229


It also includes the fix to only generate filter file for isolated_script_test if --isolated-script-test-filter flag is passed

This will make the behavior of testing/scripts/run_isolated_script_test.py matches
with what happened before the refactoring in https://chromium-review.googlesource.com/c/chromium/src/+/1278156

The bug happened because when  --isolated-script-test-filter is not passed,
TypUnittestAdapter.generate_test_filter_args() isn't called, which means the _temp_filter_file file
handle is not closed. Hence attempting to remove the file will cause a crash on Windows platform
(removing a file whose file handle opened).

In this fix, we create _temp_filter_file within TypUnittestAdapter.generate_test_filter_args() and
only clean up the file if it was created.

This also fix generate_test_filter_args to generate flags with self._temp_filter_file.name (used to beself._temp_filter_file)

TBR=kbr@chromium.org, dpranke@chromium.org, dtrainor@chromium.org

Bug: 894261,  895586 ,  895601 
Change-Id: I74255ba2bc7598db9df18cff4bff4407c2a927f8
Reviewed-on: https://chromium-review.googlesource.com/c/1281902
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599880}
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/chrome/android/monochrome/BUILD.gn
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/testing/scripts/common.py
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/testing/scripts/run_chromedriver_tests.py
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/testing/scripts/run_gpu_integration_test_as_googletest.py
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/testing/scripts/run_isolated_script_test.py
[modify] https://crrev.com/09dcd00f7f832753594286999666ddb14c796f7a/testing/scripts/run_telemetry_as_googletest.py

Status: Fixed (was: Started)

Sign in to add a comment