Viz hit-testing visual debugging scheme |
||
Issue descriptionIt is hard to debug when events have been sent to the wrong place. A visual debugging scheme would be very useful and impactful, especially for debugging out-of-process iframes (OOPIFs) targeting with Site Isolation on. This project can include many parts of debugging info: trace flow events for submitting hit-test data pipeline and event targeting and dispatching pipeline; hit-test region list when in debug mode; clients highlighting in asynchronous targeting; target highlighting; integration with devtools, etc.. After we integrate it with devtools, both end users and developers can have a better idea of where events are going/ what are the hit-test regions and would make debugging a lot easier.
,
Oct 15
The hit-test regions could eventually include touch-handler regions, but right now, it doesn't. Currently, it only contains information about OOPIFs, and this is meant to investigate correctness issues (of which there have been many with OOPIFs/browser-plugins), rather than performance issues.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f0b16c18384c1356337718e3abeace0b5a9bcee commit 3f0b16c18384c1356337718e3abeace0b5a9bcee Author: Alexander Shah <zandershah@google.com> Date: Tue Nov 13 02:24:34 2018 viz: Hit-test debug visualization linked to devtools. Example: https://screenshot.googleplex.com/tHOgDdVn6aj R=riajiang@chromium.org Bug: 895600 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I41affc1da88425ae8284bc0eef7d54aeefa124c9 Reviewed-on: https://chromium-review.googlesource.com/c/1289072 Commit-Queue: Alexander Shah <zandershah@google.com> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#607448} [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/content/renderer/gpu/layer_tree_view.cc [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/content/renderer/gpu/layer_tree_view.h [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/public/platform/web_layer_tree_view.h [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/core/exported/web_view_impl.cc [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/core/exported/web_view_impl.h [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/core/inspector/browser_protocol.pdl [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/core/inspector/inspector_overlay_agent.h [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/devtools/front_end/inspector_main/RenderingOptions.js [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/devtools/front_end/sdk/OverlayModel.js [modify] https://crrev.com/3f0b16c18384c1356337718e3abeace0b5a9bcee/third_party/blink/renderer/devtools/front_end/sdk/module.json
,
Dec 5
|
||
►
Sign in to add a comment |
||
Comment 1 by dgozman@chromium.org
, Oct 15Components: Platform>DevTools