New issue
Advanced search Search tips

Issue 895597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

show active downloads on downloadshelf

Project Member Reported by qin...@chromium.org, Oct 15

Issue description

Today if a paused download is loaded from history, it will not be shown on download shelf if user resumes the download from chrome://downloads
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed

commit 32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed
Author: Min Qin <qinmin@chromium.org>
Date: Thu Oct 18 00:14:38 2018

Show active download on shelf

Once a download becomes active, it should be shown on shelf.

BUG= 895597 

Change-Id: I307c64d2111a903ce0bc22b2bd0ae6ff1776c658
Reviewed-on: https://chromium-review.googlesource.com/c/1282023
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600615}
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/components/download/public/common/download_item.h
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/components/download/public/common/download_item_impl.h
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/components/download/public/common/mock_download_item.h
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/content/public/test/fake_download_item.cc
[modify] https://crrev.com/32b9da2a8fd8a57129a8c6f9ba3a8073cac00bed/content/public/test/fake_download_item.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb

commit d2362e5aeaef12a4c2e5a487a95e1034219bf3eb
Author: Min Qin <qinmin@chromium.org>
Date: Fri Oct 19 00:34:28 2018

Rename DownloadType to DownloadCreationType and remove DownloadHistory::WasRestoredFromHistory()

DownloadItem should know whether it is created from history.
No need to keep DownloadHistory::WasRestoredFromHistory.

BUG= 895597 

Change-Id: If8aa8c5e07a5d4d4e35edff9e37b98adefe77df7
Reviewed-on: https://chromium-review.googlesource.com/c/1289084
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600995}
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/download/download_history.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/download/download_history.h
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/download/download_history_unittest.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/chrome/browser/download/download_ui_controller_unittest.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/components/download/internal/common/download_item_impl.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/components/download/public/common/download_item.h
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/components/download/public/common/download_item_impl.h
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/components/download/public/common/mock_download_item.h
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/content/public/test/OWNERS
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/content/public/test/fake_download_item.cc
[modify] https://crrev.com/d2362e5aeaef12a4c2e5a487a95e1034219bf3eb/content/public/test/fake_download_item.h

Status: Fixed (was: Assigned)

Sign in to add a comment