Issue metadata
Sign in to add a comment
|
Make SmartLock backwards compatible |
||||||||||||||||||||||
Issue descriptionBreaking out of crbug.com/893769 . For context from there: "We are about to turn on the multidevice flags in 71 by default. In the current state, if we do that, any users whose phones either haven't gotten the GmsCore apk or flag rollout, or haven't had their phones do a CryptAuth enrollment *after* that rollout will be stuck with both of these features broken and no way to re-enable them. Note that this is only likely to affect dev and beta users since the rollout should be done by the time 71 ramps up on stable. However, my main concern with this issue is the noise that user feedback will create from this breaking change and the triaging burden we'll incur in needing to look at every report to determine whether the user is stuck in this state. If we can avoid that problem altogether, I'd like to try." Equivalent MagicTether fix: https://chromium-review.googlesource.com/c/chromium/src/+/1278542
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1be702d178b1e35e430786f4fce23b621d2cc75 commit a1be702d178b1e35e430786f4fce23b621d2cc75 Author: Josh Nohle <nohle@google.com> Date: Tue Oct 23 18:18:47 2018 [CrOS MultiDevice] Make Smart Lock work with legacy hosts Make SmartLock work after clients (chromebooks) update but before legacy hosts (phones) update. The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking SmartLock in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting EASY_UNLOCK_HOST support. In that case, the legacy SmartLock settings will be available in chrome://settings/lockScreen, fully capable of enabling/disabling. Bug: 895585 Change-Id: Iff0ebb46fac2a43f6af32b09182a621ca43b54fa Reviewed-on: https://chromium-review.googlesource.com/c/1287045 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#602025} [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/a1be702d178b1e35e430786f4fce23b621d2cc75/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.h
,
Oct 23
Previous users of Smart Lock will be broken without this change -- it needs to be present in M71. Josh and I have manually tested this change extensively.
,
Oct 23
,
Oct 23
The following scenarios were manually verified:
Note:
"New flow": some phone has BETTER_TOGETHER_HOST supported
"Legacy flow": no phone has BETTER_TOGETHER_HOST supported, but some phone has EASY_UNLOCK_HOST supported
1) "New flow": New setup flow ("Set up" button under Connected devices) works
2) "New flow": Old Smart Lock settings (under "Screen lock and sign-in") are unavailable
3) "Legacy flow": New setup flow is unavailable
4) "Legacy flow": Old Smart Lock settings are available
5) "Legacy flow": Legacy setup flow works
6) "Legacy flow": Disabling Smart Lock from "Screen lock and sign-in" settings works
7) "Legacy flow": When Smart Lock is enabled, Smart Lock works on lock screen
8) "Legacy flow": When Smart Lock is enabled and "Use Smart Lock to sign in to your Google Account" is disabled, Smart Lock is not available on the sign-in page
9) "Legacy flow": When Smart Lock is enabled and "Use Smart Lock to sign in to your Google Account" is enabled, the user is prompted to enter their password on the sign-in page, then the next time the user signs in, Smart Lock is available
10) Transition from "Legacy flow" to "New flow": When BETTER_TOGETHER_HOST becomes supported, Smart Lock will not work on the lock screen nor the sign-in screen until the user goes through the new setup flow, even if EASY_UNLOCK_HOST was enabled.
,
Oct 24
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32ee37672dd1c9edc7efc4554ba92977a8a294dc commit 32ee37672dd1c9edc7efc4554ba92977a8a294dc Author: Josh Nohle <nohle@google.com> Date: Wed Oct 24 19:29:23 2018 [CrOS MultiDevice] Make Smart Lock work with legacy hosts Make SmartLock work after clients (chromebooks) update but before legacy hosts (phones) update. The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking SmartLock in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting EASY_UNLOCK_HOST support. In that case, the legacy SmartLock settings will be available in chrome://settings/lockScreen, fully capable of enabling/disabling. Bug: 895585 Change-Id: Iff0ebb46fac2a43f6af32b09182a621ca43b54fa Reviewed-on: https://chromium-review.googlesource.com/c/1287045 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602025}(cherry picked from commit a1be702d178b1e35e430786f4fce23b621d2cc75) Reviewed-on: https://chromium-review.googlesource.com/c/1298353 Cr-Commit-Position: refs/branch-heads/3578@{#300} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.h [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/resources/settings/people_page/lock_screen.html [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/resources/settings/people_page/lock_screen.js [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc [modify] https://crrev.com/32ee37672dd1c9edc7efc4554ba92977a8a294dc/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.h
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32ee37672dd1c9edc7efc4554ba92977a8a294dc Commit: 32ee37672dd1c9edc7efc4554ba92977a8a294dc Author: nohle@google.com Commiter: hansberry@chromium.org Date: 2018-10-24 19:29:23 +0000 UTC [CrOS MultiDevice] Make Smart Lock work with legacy hosts Make SmartLock work after clients (chromebooks) update but before legacy hosts (phones) update. The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking SmartLock in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting EASY_UNLOCK_HOST support. In that case, the legacy SmartLock settings will be available in chrome://settings/lockScreen, fully capable of enabling/disabling. Bug: 895585 Change-Id: Iff0ebb46fac2a43f6af32b09182a621ca43b54fa Reviewed-on: https://chromium-review.googlesource.com/c/1287045 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602025}(cherry picked from commit a1be702d178b1e35e430786f4fce23b621d2cc75) Reviewed-on: https://chromium-review.googlesource.com/c/1298353 Cr-Commit-Position: refs/branch-heads/3578@{#300} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 25
Greg, it looks like the fix for this did not land in the latest dev-channel update (the revision in Comment #9 *just* missed the build cut-off). Apologies for the inconvenience -- Smart Lock will be visible for you again in the next dev-channel update, which will push out sometime next week.
,
Oct 25
Greg, just to clarify, is a "Set up" button available under "Connected devices" in Settings (see attached image)? If so, you're able to go through the new setup flow and access Smart Lock settings from there, and the behavior you're seeing in chrome://settings/lockScreen is expected. If "Set up" is not available, we'll have to wait until the next dev release. Thanks for the heads-up, and please let us know if you see any issues after the next dev release!
,
Oct 26
Ahh. I found the "Set up" button. Smart lock works now. :-)
,
Oct 26
SmartLock previously worked using my OnePlus 6 it shows up in the connected devices but it only shows messages and not SmartLock. Does this mean once this is rolled out next week to Dev I should be able to use SmartLock like normal again?
,
Oct 26
If you're able to go through the setup mentioned above (via the "Set Up" button under "Connected devices"), then this change shouldn't be relevant to you. Control of Smart Lock, tethering, and Messages should occur in the settings under "Connected devices". If Smart Lock is not appearing in those settings, then it must be unsupported for some reason. However, this change and related changes don't affect that state. Make sure that bluetooth is enabled and a lock screen is set up on the phone, for instance.
,
Oct 29
Thanks for the report! With Smart Lock exiting beta with the launch of the new connected phone experience, we are slowly ramping up phone-side support for Smart Lock in line with the M71 roll out. While we don't have an exact timeline to share right now, we anticipate your phone will work with Smart Lock again very soon, likely no later than when M71 hits stable channel.
,
Nov 3
I updated to Chrome OS Dev 72 and Smart Lock still doesn't appear under the better together settings only messages. My devices are the OnePlus 6 and Asus C302 (Cave) and I'm pretty sure others have said it works for them. Should I report a bug or do I just need to wait longer?
,
Nov 5
Hi linkofhyruleuo@, unfortunately you'll need to wait a bit longer for your phone to re-enable SmartLock. It's a bit of luck of the draw here as we ramp up our experiment group. You should have everything back and workthing within the next week or two, though.
,
Nov 6
Ok thanks for the reply hopefully by the end of the month anyways. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hansberry@chromium.org
, Oct 23