Make HeadsUpDisplayLayerImpl use RasterInterface instead of GLES2Interface |
|||||||||||
Issue descriptionGLES2Interface may not available with Vulkan backend, so we should switch to RasterInterface.
,
Oct 15
+CC enne@, danakj@ IIRC, the reason why HUD supports GPU raster and CPU raster is to minimize effects on performance when the HUD is turned on. Maybe enne@ or danakj@ can confirm. If this is true we should OOP-R the HUD and use RasterInterface/RasterDecoder when we CPU raster or OOP-R. We might not be able to completely remove GLES2Interface until we no longer GPU raster. OOP-R needs a RasterDecoder, so this could complicate plumbing of the context client side.
,
Oct 15
Yes, that is the reason why. I think OOP-R-ing the hud makes sense when OOP-R is supported and software rastering otherwise. (We have some current weird transitional blacklist entries where OOP-R is blacklisted but GPU-R is not. I think the hud can software raster in those cases if it makes life easier.)
,
Oct 16
,
Oct 18
,
Oct 24
,
Oct 29
,
Oct 29
,
Oct 29
,
Oct 29
,
Nov 16
***UI Mass Triage*** Seems work is in progress, adding appropriate labels. penghuang@, Please update the thread accordingly. Thanks..!
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25718190ae3ed7f0648d5f7df3b04e096f9924d9 commit 25718190ae3ed7f0648d5f7df3b04e096f9924d9 Author: Peng Huang <penghuang@chromium.org> Date: Sat Nov 17 00:00:32 2018 Using PaintCanvas for HUD To support OOPR, we need switch from SkCanvas to PaintCanvas which is for OOPR. Bug: 895568 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad Reviewed-on: https://chromium-review.googlesource.com/c/1286950 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#609033} [modify] https://crrev.com/25718190ae3ed7f0648d5f7df3b04e096f9924d9/cc/layers/heads_up_display_layer_impl.cc [modify] https://crrev.com/25718190ae3ed7f0648d5f7df3b04e096f9924d9/cc/layers/heads_up_display_layer_impl.h
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7218ea22c535f59f4164fb0cfd0fa42cf2f66152 commit 7218ea22c535f59f4164fb0cfd0fa42cf2f66152 Author: Peng Huang <penghuang@chromium.org> Date: Mon Nov 19 16:56:53 2018 Revert "Using PaintCanvas for HUD" This reverts commit 25718190ae3ed7f0648d5f7df3b04e096f9924d9. Reason for revert: It breaks FPS counter on Mac https://bugs.chromium.org/p/chromium/issues/detail?id=906570 Original change's description: > Using PaintCanvas for HUD > > To support OOPR, we need switch from SkCanvas to PaintCanvas which is for > OOPR. > > Bug: 895568 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad > Reviewed-on: https://chromium-review.googlesource.com/c/1286950 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609033} TBR=penghuang@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895568 , 906570 Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1342049 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609333} [modify] https://crrev.com/7218ea22c535f59f4164fb0cfd0fa42cf2f66152/cc/layers/heads_up_display_layer_impl.cc [modify] https://crrev.com/7218ea22c535f59f4164fb0cfd0fa42cf2f66152/cc/layers/heads_up_display_layer_impl.h
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d087e98821e7bf15d27c5b0de0ff8d6743e7469 commit 3d087e98821e7bf15d27c5b0de0ff8d6743e7469 Author: Peng Huang <penghuang@chromium.org> Date: Thu Nov 22 23:27:39 2018 Reland "Using PaintCanvas for HUD" Original change's description: > Revert "Using PaintCanvas for HUD" > > This reverts commit 25718190ae3ed7f0648d5f7df3b04e096f9924d9. > > Reason for revert: It breaks FPS counter on Mac > https://bugs.chromium.org/p/chromium/issues/detail?id=906570 > > Original change's description: > > Using PaintCanvas for HUD > > > > To support OOPR, we need switch from SkCanvas to PaintCanvas which is for > > OOPR. > > > > Bug: 895568 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I94b5430c7ee8ed2f5140d352214ec43f2ff0f8ad > > Reviewed-on: https://chromium-review.googlesource.com/c/1286950 > > Commit-Queue: Peng Huang <penghuang@chromium.org> > > Reviewed-by: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609033} > > TBR=penghuang@chromium.org,enne@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 895568 , 906570 > Change-Id: I935de60977c0374139ae1eb22670d234f85e0df6 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1342049 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609333} TBR=penghuang@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895568 , 906570 Change-Id: I65448fa5e72d1aa9bf79aa8513944f2ce953b91f Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1348864 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610501} [modify] https://crrev.com/3d087e98821e7bf15d27c5b0de0ff8d6743e7469/cc/layers/heads_up_display_layer_impl.cc [modify] https://crrev.com/3d087e98821e7bf15d27c5b0de0ff8d6743e7469/cc/layers/heads_up_display_layer_impl.h
,
Nov 26
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by penghuang@chromium.org
, Oct 15