Unify the redirect blocking + pop-up blocking code |
||
Issue descriptionRight now, Chrome has a pop-up blocker and a redirect blocker. These surfaces are almost identical, and should share most of the same similarity. However, this similarity is _not_ reflected in the code. I think we can reasonably merge the framebust_block_tab_helper and the popup_blocker_tab_helper into a single blocked_navigation_tab_helper, with two separate instances (and slightly different configuration options).
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b718554b61b113f78c4fe5d9531931dc98f0a63f commit b718554b61b113f78c4fe5d9531931dc98f0a63f Author: Charlie Harrison <csharrison@chromium.org> Date: Wed Oct 31 15:04:11 2018 Remove Framebust logic from TabSpecificContentSettings We aren't actually using anything intrinsic to the class, so there is no point. Note: This CL also removes a TODO to add _more_ framebust logic to TabSpecificContentSettings. Since there are multiple UIs that interact with the POPUP setting, it seems best to have a separate class deal with that state, and eventually move popup stuff out of there. Bug: 895555 Change-Id: Ifc1de176525c30972a4a00ac2c90b2c44f339f0b Reviewed-on: https://chromium-review.googlesource.com/c/1283411 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#604254} [modify] https://crrev.com/b718554b61b113f78c4fe5d9531931dc98f0a63f/chrome/browser/content_settings/tab_specific_content_settings.cc [modify] https://crrev.com/b718554b61b113f78c4fe5d9531931dc98f0a63f/chrome/browser/content_settings/tab_specific_content_settings.h [modify] https://crrev.com/b718554b61b113f78c4fe5d9531931dc98f0a63f/chrome/browser/ui/blocked_content/framebust_block_tab_helper.cc [modify] https://crrev.com/b718554b61b113f78c4fe5d9531931dc98f0a63f/chrome/browser/ui/blocked_content/tab_under_navigation_throttle.cc [modify] https://crrev.com/b718554b61b113f78c4fe5d9531931dc98f0a63f/chrome/browser/ui/browser.cc
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb1de6287e02c927e028bb05a34822daafb33cea commit bb1de6287e02c927e028bb05a34822daafb33cea Author: Charlie Harrison <csharrison@chromium.org> Date: Wed Nov 21 13:44:06 2018 Introduce the UrlListManager This CL introduces the skeleton of a class which can drive the UI of "blocked URL" lists (i.e. the popup and redirect setting bubbles). Currently, it only exposes an observer interface to unify how popup and redirect UI surfaces receive updates about new URLs that were blocked. Follow-up CLs can add functionality including storing the actual blocked URLs within the manager. Bug: 895555 Change-Id: I6e95cd4ca3c8d6109cbfdb770516dc6d18c98554 Reviewed-on: https://chromium-review.googlesource.com/c/1334420 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610035} [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/framebust_block_tab_helper.cc [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/framebust_block_tab_helper.h [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h [add] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/url_list_manager.cc [add] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/blocked_content/url_list_manager.h [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/content_settings/content_setting_bubble_model.cc [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/content_settings/content_setting_bubble_model.h [modify] https://crrev.com/bb1de6287e02c927e028bb05a34822daafb33cea/chrome/browser/ui/content_settings/framebust_block_browsertest.cc
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 16