New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 895553 link

Starred by 1 user
Status: Fixed
Owner:
█ jkwang@chromium.org
User never visited
Closed: Oct 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

bogus bus type in gamepad test data

Project Member Reported by spang@google.com, Oct 15 
The bustype property is wrong in the data data for several gamepads:

https://cs.chromium.org/chromium/src/ui/events/ozone/evdev/event_device_test_util.cc?q=bustype+file:event_device_test_util&sq=package:chromium&dr=CSs&l=95

This is I8042 which is obviously wrong; several tests will fail if we start using the bustype from input_id to determine if devices are internal or external.

Let's capture the following data again using capture_device_capabilities.py :

kHJCGamepad
kXboxGamepad
kiBuffaloGamepad
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb46e5bc4ec81e577c53e7f98e854c7630d9b33d

commit cb46e5bc4ec81e577c53e7f98e854c7630d9b33d
Author: Michael Spang <spang@chromium.org>
Date: Mon Oct 15 22:51:40 2018

ozone: evdev: Add note to use the python script for test data

Add a note that explains how to capture device capabilities for tests to
avoid errors in manually entered data.

Also make the script capture all devices if none are specified, so that
it's easier to run.

Bug:  895553 
Test: ui/events/ozone/evdev/capture_device_capabilities.py

Change-Id: I84ca174077cd77a89e8adf59570e9e33e1fd04a9

Reviewed-on: https://chromium-review.googlesource.com/c/1281232
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599764}
[modify] https://crrev.com/cb46e5bc4ec81e577c53e7f98e854c7630d9b33d/ui/events/ozone/evdev/capture_device_capabilities.py
[modify] https://crrev.com/cb46e5bc4ec81e577c53e7f98e854c7630d9b33d/ui/events/ozone/evdev/event_device_test_util.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/101c7178f2750575dbd228735f0893fa1a0d916b

commit 101c7178f2750575dbd228735f0893fa1a0d916b
Author: Jingkui Wang <jkwang@google.com>
Date: Mon Oct 22 18:54:22 2018

fix ozone evdev gamepad tests

Capture capabilities and events

Bug:  895553 
Test: build/run events_unittests
Change-Id: I9c09a8646017ad36b0f4c61c39f4ad20121b61aa
Reviewed-on: https://chromium-review.googlesource.com/c/1290090
Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601670}
[modify] https://crrev.com/101c7178f2750575dbd228735f0893fa1a0d916b/ui/events/ozone/evdev/event_device_test_util.cc
[modify] https://crrev.com/101c7178f2750575dbd228735f0893fa1a0d916b/ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc

Comment 3 by spang@google.com, Oct 22

Status: Fixed (was: Untriaged)
►

Sign in to add a comment