New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 895548 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Enhancement


Previous locations:
monorail:4402


Sign in to add a comment

Improvement for the divider in dev tools for web socket frame monitoring

Reported by girard.s...@gmail.com, Oct 15

Issue description

What do you want?
The divider to view the data in a websocket connection can be pulled all the way up in a way that's impossible to see that there is a divider, effectively hiding the frames that have arrived. The user is left to think that something is wrong in dev tools.

Why do you want it?
Because it costs time for quite a few devs.

See https://stackoverflow.com/questions/44533111/chrome-59-websocket-frames-no-longer-visible-in-devtools
 
Project: chromium
Moved issue monorail:4402 to now be  issue chromium:895548 .
Components: Platform>DevTools
Status: Untriaged (was: New)
Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11e27edef40a486fd916a989851a0066e2983c66

commit 11e27edef40a486fd916a989851a0066e2983c66
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Oct 16 21:51:11 2018

DevTools: Set a minimum height on the WebSocketFrameView

This prevents the user from accidentally hiding the frame view
completely and being unable to figure out how to get it back.

Bug:  895548 
Change-Id: I39f503faa680bc136b14e6e521a1528ab594feff
Reviewed-on: https://chromium-review.googlesource.com/c/1281873
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600136}
[modify] https://crrev.com/11e27edef40a486fd916a989851a0066e2983c66/third_party/blink/renderer/devtools/front_end/network/ResourceWebSocketFrameView.js

Actually, on my 2560 x 1600 MacBook Pro 13' it is hidden by default in dock on bottom side.
It was also hidden by default on my Mac Pro OSX 10.13 and Fedora 28 laptop. The issue has been viewed nearly 6k times, at the time of this comment.
Status: Fixed (was: Assigned)
Cc: jarhar@chromium.org sc00335...@techmahindra.com
 Issue 778350  has been merged into this issue.
 Issue 770713  has been merged into this issue.

Sign in to add a comment