New issue
Advanced search Search tips

Issue 895529 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

x-domain frames don't work in findinpage frameDocs

Project Member Reported by thegreenfrog@chromium.org, Oct 15

Issue description

Currently x-domain frames are not included when calling findinpage frameDocs javascript function.
 
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Available)
**UI Mass Triage**

We were unable to find repro steps for this bug. If you have more data to reproduce this bug or have clear repro steps, please reopen or file a new issue.
Thanks!
Labels: -Type-Bug OS-iOS Type-Feature
Status: Available (was: WontFix)
thegreenfrog@, be sure to set the platform when creating iOS bugs. I think that may have excluded this from the mass update. Also, I'll move this to be a Feature instead of a Bug since its existing behavior that wasn't possible before and now we can improve it.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f

commit 5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Tue Jan 15 00:47:59 2019

[ios] Refactor //ios/web find_in_page.js search

Changes highlightWord nomenclature to findString, and removes logic that
searches through all child frames. Refactor pumpSearch to not highlight
first result. findString and pumpSearch also only returns numerical value
of matches since decision which frame to highligh/scroll to is done by
manager.

Bug: 896867, 895529
Change-Id: Ib71ffaffda96e20a0e0721df0085476e998ae017
Reviewed-on: https://chromium-review.googlesource.com/c/1387045
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622662}
[modify] https://crrev.com/5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f/ios/web/BUILD.gn
[add] https://crrev.com/5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f/ios/web/web_state/js/find_in_page_unittest.mm
[modify] https://crrev.com/5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f/ios/web/web_state/js/resources/find_in_page.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c893b0aafa24f476849fc0d4d61cd450f5255c4

commit 7c893b0aafa24f476849fc0d4d61cd450f5255c4
Author: Dominic Battré <battre@chromium.org>
Date: Tue Jan 15 09:12:39 2019

Revert "[ios] Refactor //ios/web find_in_page.js search"

This reverts commit 5968f8fc2c5c9e3d830fe48d5a9bbd1b3ac5489f.

Reason for revert: Broken test, see crbug.com/896867

Original change's description:
> [ios] Refactor //ios/web find_in_page.js search
> 
> Changes highlightWord nomenclature to findString, and removes logic that
> searches through all child frames. Refactor pumpSearch to not highlight
> first result. findString and pumpSearch also only returns numerical value
> of matches since decision which frame to highligh/scroll to is done by
> manager.
> 
> Bug: 896867, 895529
> Change-Id: Ib71ffaffda96e20a0e0721df0085476e998ae017
> Reviewed-on: https://chromium-review.googlesource.com/c/1387045
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
> Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622662}

TBR=eugenebut@chromium.org,michaeldo@chromium.org,thegreenfrog@chromium.org

Change-Id: I9c5339b5561c152c3c90d68114bfb24813053bf0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896867, 895529
Reviewed-on: https://chromium-review.googlesource.com/c/1411336
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622791}
[modify] https://crrev.com/7c893b0aafa24f476849fc0d4d61cd450f5255c4/ios/web/BUILD.gn
[delete] https://crrev.com/630b98c03608a241cfca63c1c47576c8c178b5f7/ios/web/web_state/js/find_in_page_unittest.mm
[modify] https://crrev.com/7c893b0aafa24f476849fc0d4d61cd450f5255c4/ios/web/web_state/js/resources/find_in_page.js

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2162251259f92f0b95f0bc25a570357e4e5fb509

commit 2162251259f92f0b95f0bc25a570357e4e5fb509
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Wed Jan 16 01:59:14 2019

[ios] Refactor //ios/web find_in_page.js search

Changes highlightWord nomenclature to findString, and removes logic that
searches through all child frames. Refactor pumpSearch to not highlight
first result. findString and pumpSearch also only returns numerical value
of matches since decision which frame to highligh/scroll to is done by
manager.

Bug: 896867, 895529
Change-Id: I7693a073181b5f9c6ec8b9a0ed21b9f05012793f
Reviewed-on: https://chromium-review.googlesource.com/c/1412593
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623017}
[modify] https://crrev.com/2162251259f92f0b95f0bc25a570357e4e5fb509/ios/web/BUILD.gn
[add] https://crrev.com/2162251259f92f0b95f0bc25a570357e4e5fb509/ios/web/web_state/js/find_in_page_unittest.mm
[modify] https://crrev.com/2162251259f92f0b95f0bc25a570357e4e5fb509/ios/web/web_state/js/resources/find_in_page.js

Sign in to add a comment