New issue
Advanced search Search tips

Issue 895515 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[FCP++] Deal with too much nodes

Project Member Reported by maxlg@chromium.org, Oct 15

Issue description

The current solution has a hash map and hash set that store the all entries of the nodes. To ensure the memory consumption to be under limit. We set a cap to the number of nodes they can store. When the number of nodes exceeds the limit, the metrics stop considering new nodes.

This create limitation for the metrics to deal with large number of nodes. We need to investigate how to set a proper node limit, and whether there is a better alternative to the current approach of ignoring new nodes.
 
Description: Show this description

Comment 2 by maxlg@chromium.org, Jan 17 (5 days ago)

Ideally we should have data telling us the distribution of the number of recorded nodes. With that data available we can set a cap at 99.9%, for example. Once the cap is reached, we stop recording new nodes.

We already have a cap being 5000 though, but more work is needed to explore whether there is a better number.

Sign in to add a comment