New issue
Advanced search Search tips

Issue 895514 link

Starred by 2 users
Status: Fixed
Owner:
a...@chromium.org
Closed: Oct 25
Cc:
tapted@chromium.org
ellyjo...@chromium.org
ccameron@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 891699



Sign in to add a comment

Move client cert selector to MacViews, remove old Cocoa constrained window sheet code

Project Member Reported by a...@chromium.org, Oct 15 
Splitting from bug 891699.

https://chromium-review.googlesource.com/c/1277578 re-moved the cert viewer to be MacViews-based. We need to move the client cert selector to do the same thing, and then basically delete all these files:
        "cocoa/single_web_contents_dialog_manager_cocoa.h",
        "cocoa/single_web_contents_dialog_manager_cocoa.mm",
        "cocoa/constrained_window/constrained_window_mac.h",
        "cocoa/constrained_window/constrained_window_mac.mm",
        "cocoa/constrained_window/constrained_window_sheet.h",
        "cocoa/constrained_window/constrained_window_sheet_controller.h",
        "cocoa/constrained_window/constrained_window_sheet_controller.mm",
        "cocoa/constrained_window/constrained_window_sheet_info.h",
        "cocoa/constrained_window/constrained_window_sheet_info.mm",
(in fact probably delete all of cocoa/constrained_window/*)
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3edfd2d98b22df221e8fb76fe77a536b029719d

commit c3edfd2d98b22df221e8fb76fe77a536b029719d
Author: Avi Drissman <avi@chromium.org>
Date: Thu Oct 25 20:01:03 2018

Port the client cert selector to use MacViews.

This also renames the "WorkaroundCrashySierra" test to
"WorkaroundTableViewCrash" as it reliably crashes on 10.11
too, and re-enables the test as the crash workaround is
changed to be more aggressively applied. (Fingers crossed.)

BUG= 895514 , 810909 

Change-Id: Ife4529f348d1ed8940c72d392ee207f5e227a3f4
Reviewed-on: https://chromium-review.googlesource.com/c/1287316
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602834}
[modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ssl/ssl_client_certificate_selector.h
[modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
[delete] https://crrev.com/3773b61598fc9e6e3a947ae74cb0cd2f45a6dbfc/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm
[modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector.cc
[add] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac.h
[add] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac.mm
[rename] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/browser/ui/views/ssl_client_certificate_selector_mac_browsertest.mm
[modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/chrome/test/BUILD.gn
[modify] https://crrev.com/c3edfd2d98b22df221e8fb76fe77a536b029719d/testing/buildbot/filters/mac_window_server_killers.browser_tests.filter
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c935f0bd613a2527ce4759192719812ea70c867

commit 2c935f0bd613a2527ce4759192719812ea70c867
Author: Avi Drissman <avi@chromium.org>
Date: Thu Oct 25 23:03:07 2018

Remove now-unused constrained window code.

BUG= 895514 , 845389

Change-Id: I7e44184c8a88b3e905fe26fd131a4900969c8f48
Reviewed-on: https://chromium-review.googlesource.com/c/1287326
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602916}
[modify] https://crrev.com/2c935f0bd613a2527ce4759192719812ea70c867/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.mm
[modify] https://crrev.com/2c935f0bd613a2527ce4759192719812ea70c867/chrome/test/BUILD.gn

Comment 3 by thakis@chromium.org, Oct 25

Blocking: 891699

Comment 4 by a...@chromium.org, Oct 25

Status: Fixed (was: Started)
►

Sign in to add a comment